samples/poppopwin: upgrade to first-class sample

samples/pop-pop-win/web/platform_web.dart

Index: samples/pop-pop-win/web/platform_web.dart
diff --git a/samples/third_party/pop-pop-win/web/platform_web.dart b/samples/pop-pop-win/web/platform_web.dart
similarity index 89%
rename from samples/third_party/pop-pop-win/web/platform_web.dart
rename to samples/pop-pop-win/web/platform_web.dart
index 721066d2a74f79996d85f4ab498eed606f6cb401..7362b97a0c8b2c64ec0cdd76d3bf9e2bd2840e4e 100644
--- a/samples/third_party/pop-pop-win/web/platform_web.dart
+++ b/samples/pop-pop-win/web/platform_web.dart
@@ -54,11 +54,11 @@ class PlatformWeb extends PlatformTarget {
   Stream get aboutChanged => _aboutController.stream;
 
   void toggleAbout([bool value]) {
-    final Location loc = window.location;
+    var loc = window.location;
     // ensure we treat empty hash like '#', which makes comparison easy later
-    final hash = loc.hash.length == 0 ? '#' : loc.hash;
+    var hash = loc.hash.length == 0 ? '#' : loc.hash;
 
-    final isOpen = hash == _ABOUT_HASH;
+    var isOpen = hash == _ABOUT_HASH;
     if(value == null) {
       // then toggle the current value
       value = !isOpen;
@@ -74,9 +74,9 @@ class PlatformWeb extends PlatformTarget {
   String get _urlHash => window.location.hash;
 
   void _processUrlHash() {
-    final Location loc = window.location;
-    final hash = loc.hash;
-    final href = loc.href;
+    var loc = window.location;

[Jennifer Messerly, 2014/03/19 01:06:54]

fwiw, nothing wrong with using "final". It seems to give better inference in the
Editor sometimes. And better VM performance. I do dislike "final TypeName
variableName = ..." tho.

"var" is fine too of course! This is just an FYI comment.

[kevmoo, 2014/03/19 03:24:06]

Just trying to align w/ our general code guidelines.

[Jennifer Messerly, 2014/03/19 14:26:43]

makes sense :)

+    var hash = loc.hash;
+    var href = loc.href;
 
     final History history = window.history;
     switch(hash) {
@@ -89,7 +89,7 @@ class PlatformWeb extends PlatformTarget {
         loc.replace(newLoc);
         break;
       case _BIG_HASH:
-        loc.reload();
+        if (!renderBig) loc.reload();
         break;
       case _ABOUT_HASH:
         _aboutController.add(null);