samples/poppopwin: upgrade to first-class sample

samples/pop-pop-win/web/platform_web.dart

 library ppw_platform_web;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:js' as js;
 import 'package:poppopwin/platform_target.dart';
 
 class PlatformWeb extends PlatformTarget {
   static const String _BIG_HASH = '#big';
   static const String _ABOUT_HASH = '#about';
@@ skipping 36 matching lines @@
     js.context.callMethod('ga', args);
   }
 
   bool get renderBig => _urlHash == _BIG_HASH;
 
   bool get showAbout => _urlHash == _ABOUT_HASH;
 
   Stream get aboutChanged => _aboutController.stream;
 
   void toggleAbout([bool value]) {
-    final Location loc = window.location;
+    var loc = window.location;
     // ensure we treat empty hash like '#', which makes comparison easy later
-    final hash = loc.hash.length == 0 ? '#' : loc.hash;
+    var hash = loc.hash.length == 0 ? '#' : loc.hash;
 
-    final isOpen = hash == _ABOUT_HASH;
+    var isOpen = hash == _ABOUT_HASH;
     if(value == null) {
       // then toggle the current value
       value = !isOpen;
     }
 
     var targetHash = value ? _ABOUT_HASH : '#';
     if(targetHash != hash) {
       loc.assign(targetHash);
     }
     _aboutController.add(null);
   }
 
   String get _urlHash => window.location.hash;
 
   void _processUrlHash() {
-    final Location loc = window.location;
-    final hash = loc.hash;
-    final href = loc.href;
+    var loc = window.location;

[Jennifer Messerly, 2014/03/19 01:06:54]

fwiw, nothing wrong with using "final". It seems to give better inference in the
Editor sometimes. And better VM performance. I do dislike "final TypeName
variableName = ..." tho.

"var" is fine too of course! This is just an FYI comment.

[kevmoo, 2014/03/19 03:24:06]

Just trying to align w/ our general code guidelines.

[Jennifer Messerly, 2014/03/19 14:26:43]

makes sense :)

+    var hash = loc.hash;
+    var href = loc.href;
 
     final History history = window.history;
     switch(hash) {
       case "#reset":
         assert(href.endsWith(hash));
         var newLoc = href.substring(0, href.length - hash.length);
 
         window.localStorage.clear();
 
         loc.replace(newLoc);
         break;
       case _BIG_HASH:
-        loc.reload();
+        if (!renderBig) loc.reload();
         break;
       case _ABOUT_HASH:
         _aboutController.add(null);
         break;
     }
   }
 }