Use new is*Element() helper functions more in web/ code

Use new is*Element() helper functions more in web/ code

Use new is*Element() helpers more in web/ code. This makes the code clearer
and simpler.

R=eseidel, adamk, tkent
BUG=346095
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169318

[adamk, 2014-03-14 20:49:12]

lgtm

https://codereview.chromium.org/200723002/diff/1/Source/web/ChromeClientImpl.cpp
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/200723002/diff/1/Source/web/ChromeClientImpl....
Source/web/ChromeClientImpl.cpp:549: &&
(isHTMLObjectElement(*result.innerNonSharedNode())
I liked the original indentation better, but I'm guessing lint didn't?

https://codereview.chromium.org/200723002/diff/1/Source/web/WebFrameImpl.cpp
File Source/web/WebFrameImpl.cpp (right):

https://codereview.chromium.org/200723002/diff/1/Source/web/WebFrameImpl.cpp#...
Source/web/WebFrameImpl.cpp:2266: Node* host =
node->deprecatedShadowAncestorNode();
This could be changed to:

if (node) {
  if (Node* host = node->shadowHost()) {
    ...
  }
}

to avoid the call to deprecatedShadowAncestorNode() instead of adding the ASSERT

[Inactive, 2014-03-14 21:07:17]

tkent@, could you please take a look at public/?

https://codereview.chromium.org/200723002/diff/1/Source/web/ChromeClientImpl.cpp
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/200723002/diff/1/Source/web/ChromeClientImpl....
Source/web/ChromeClientImpl.cpp:549: &&
(isHTMLObjectElement(*result.innerNonSharedNode())
On 2014/03/14 20:49:12, adamk wrote:
> I liked the original indentation better, but I'm guessing lint didn't?

Yes, the style script complained about indentation.

https://codereview.chromium.org/200723002/diff/1/Source/web/WebFrameImpl.cpp
File Source/web/WebFrameImpl.cpp (right):

https://codereview.chromium.org/200723002/diff/1/Source/web/WebFrameImpl.cpp#...
Source/web/WebFrameImpl.cpp:2266: Node* host =
node->deprecatedShadowAncestorNode();
On 2014/03/14 20:49:12, adamk wrote:
> This could be changed to:
> 
> if (node) {
>   if (Node* host = node->shadowHost()) {
>     ...
>   }
> }
> 
> to avoid the call to deprecatedShadowAncestorNode() instead of adding the
ASSERT

Done.

[tkent, 2014-03-16 23:45:51]

lgtm.

Though I'm not a fan of replacing every hasTagName with isHTMLFoo, this CL is
harmless anyway.

https://codereview.chromium.org/200723002/diff/20001/public/platform/WebPriva...
File public/platform/WebPrivatePtr.h (right):

https://codereview.chromium.org/200723002/diff/20001/public/platform/WebPriva...
public/platform/WebPrivatePtr.h:236: T& operator*() const { ASSERT(get());
return *get(); }
We don't write multiple statements in a single line.  Please follow the format
of operator-> below.

[Inactive, 2014-03-16 23:53:50]

https://codereview.chromium.org/200723002/diff/20001/public/platform/WebPriva...
File public/platform/WebPrivatePtr.h (right):

https://codereview.chromium.org/200723002/diff/20001/public/platform/WebPriva...
public/platform/WebPrivatePtr.h:236: T& operator*() const { ASSERT(get());
return *get(); }
On 2014/03/16 23:45:51, tkent wrote:
> We don't write multiple statements in a single line.  Please follow the format
> of operator-> below.

Done.

[Inactive, 2014-03-16 23:54:02]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-03-16 23:54:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/200723002/40001

[Inactive, 2014-03-16 23:54:44]

The CQ bit was unchecked by ch.dumez@samsung.com

[Inactive, 2014-03-16 23:56:08]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-03-16 23:56:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/200723002/60001

[commit-bot: I haz the power, 2014-03-17 00:48:18]

Change committed as 169318