Use new is*Element() helper functions more in web/ code

Source/web/WebSearchableFormData.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 117 matching lines @@
     }
     return !initialSelected || initialSelected->selected();
 }
 
 // Returns true if the form element is in its default state, false otherwise.
 // The default state is the state of the form element on initial load of the
 // page, and varies depending upon the form element. For example, a checkbox is
 // in its default state if the checked state matches the state of the checked attribute.
 bool IsInDefaultState(HTMLFormControlElement* formElement)
 {
-    if (formElement->hasTagName(HTMLNames::inputTag)) {
-        const HTMLInputElement* inputElement = toHTMLInputElement(formElement);
-        if (inputElement->isCheckbox() || inputElement->isRadioButton())
-            return inputElement->checked() == inputElement->hasAttribute(checkedAttr);
-    } else if (formElement->hasTagName(HTMLNames::selectTag)) {
+    ASSERT(formElement);
+    if (isHTMLInputElement(*formElement)) {
+        const HTMLInputElement& inputElement = toHTMLInputElement(*formElement);
+        if (inputElement.isCheckbox() || inputElement.isRadioButton())
+            return inputElement.checked() == inputElement.hasAttribute(checkedAttr);
+    } else if (isHTMLSelectElement(*formElement)) {
         return IsSelectInDefaultState(toHTMLSelectElement(formElement));
     }
     return true;
 }
 
 // Look for a suitable search text field in a given HTMLFormElement
 // Return nothing if one of those items are found:
 //  - A text area field
 //  - A file upload field
 //  - A Password field
 //  - More than one text field
 HTMLInputElement* findSuitableSearchInputElement(const HTMLFormElement* form)
 {
     HTMLInputElement* textElement = 0;
     const Vector<FormAssociatedElement*>& element = form->associatedElements();
     for (Vector<FormAssociatedElement*>::const_iterator i(element.begin()); i != element.end(); ++i) {
         if (!(*i)->isFormControlElement())
             continue;
 
         HTMLFormControlElement* control = toHTMLFormControlElement(*i);
 
         if (control->isDisabledFormControl() || control->name().isNull())
             continue;
 
-        if (!IsInDefaultState(control) || control->hasTagName(textareaTag))
+        if (!IsInDefaultState(control) || isHTMLTextAreaElement(*control))
             return 0;
 
-        if (control->hasTagName(HTMLNames::inputTag) && control->willValidate()) {
-            const HTMLInputElement* input = toHTMLInputElement(control);
+        if (isHTMLInputElement(*control) && control->willValidate()) {
+            const HTMLInputElement& input = toHTMLInputElement(*control);
 
             // Return nothing if a file upload field or a password field are found.
-            if (input->isFileUpload() || input->isPasswordField())
+            if (input.isFileUpload() || input.isPasswordField())
                 return 0;
 
-            if (input->isTextField()) {
+            if (input.isTextField()) {
                 if (textElement) {
                     // The auto-complete bar only knows how to fill in one value.
                     // This form has multiple fields; don't treat it as searchable.
                     return 0;
                 }
                 textElement = toHTMLInputElement(control);
             }
         }
     }
     return textElement;
@@ skipping 95 matching lines @@
 
     String action(formElement->action());
     KURL url(formElement->document().completeURL(action.isNull() ? "" : action));
     RefPtr<FormData> formData = FormData::create(encodedString);
     url.setQuery(formData->flattenToString());
     m_url = url;
     m_encoding = String(encoding.name());
 }
 
 } // namespace blink