chrome/test/data/extensions/api_test/extension_resource_request_policy/some_accessible/private.html - Issue 2007133004: Disallow navigation to documents not explicitly listed as web accessible.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/extension_resource_request_policy/some_accessible/private.html

Issue 2007133004: Disallow navigation to documents not explicitly listed as web accessible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix up subframe cases. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_protocols_unittest.cc ('K') | « chrome/test/data/extensions/api_test/extension_resource_request_policy/some_accessible/manifest.json ('k') | chrome/test/data/extensions/api_test/extension_resource_request_policy/some_accessible/public.html » ('j') | chrome/test/data/extensions/api_test/extension_resource_request_policy/some_accessible/public.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head><title>Private</title></head>

	3 <body>

	4 Private

	5 <script src="private.js"></script>
	asargent_no_longer_on_chrome 2016/05/31 18:17:38 looks like private.js is missing from CL - I guess looks like private.js is missing from CL - I guess the test in extension_resource_request_policy_apitest.cc verifies that we don't even try to load private.html, so you could just drop the script tag here. nasko 2016/05/31 23:16:17 Done. Show quoted text On 2016/05/31 18:17:38, Antony Sargent wrote: > looks like private.js is missing from CL - I guess the test in > extension_resource_request_policy_apitest.cc verifies that we don't even try to > load private.html, so you could just drop the script tag here. > > Done.
	6 </body>

	7 </html>

OLD	NEW