Disallow navigation to documents not explicitly listed as web accessible.

chrome/browser/extensions/extension_protocols_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
 
 #include "base/files/file_util.h"
@@ skipping 180 matching lines @@
     std::string name;
     bool incognito_split_mode;
     bool incognito_enabled;
 
     // Expected results.
     bool should_allow_main_frame_load;
     bool should_allow_sub_frame_load;
   } cases[] = {
     {"spanning disabled", false, false, false, false},
     {"split disabled", true, false, false, false},
-    {"spanning enabled", false, true, false, true},
-    {"split enabled", true, true, true, true},
+    {"spanning enabled", false, true, false, false},
+    {"split enabled", true, true, true, false},
   };
 
   for (size_t i = 0; i < arraysize(cases); ++i) {
     scoped_refptr<Extension> extension =
         CreateTestExtension(cases[i].name, cases[i].incognito_split_mode);
     extension_info_map_->AddExtension(
         extension.get(), base::Time::Now(), cases[i].incognito_enabled, false);
 
     // First test a main frame request.
     {
@@ skipping 126 matching lines @@
 TEST_F(ExtensionProtocolTest, AllowFrameRequests) {
   // Register a non-incognito extension protocol handler.
   SetProtocolHandler(false);
 
   scoped_refptr<Extension> extension = CreateTestExtension("foo", false);
   extension_info_map_->AddExtension(extension.get(),
                                     base::Time::Now(),
                                     false,
                                     false);
 
   // All MAIN_FRAME and SUB_FRAME requests should succeed.

[asargent_no_longer_on_chrome, 2016/05/31 18:17:38]

nit: mind updating this comment? Something like "All MAIN_FRAME requests should
succeed but SUB_FRAME requests that aren't in web_accesible_resources or a
same-origin parent should not"

[nasko, 2016/05/31 23:16:17]

Done.

   {
     std::unique_ptr<net::URLRequest> request(
         resource_context_.GetRequestContext()->CreateRequest(
             extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
             &test_delegate_));
     StartRequest(request.get(), content::RESOURCE_TYPE_MAIN_FRAME);
     EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
   }
   {
     std::unique_ptr<net::URLRequest> request(
         resource_context_.GetRequestContext()->CreateRequest(
             extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
             &test_delegate_));
     StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
-    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
+    EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
   }
 
   // And subresource types, such as media, should fail.
   {
     std::unique_ptr<net::URLRequest> request(
         resource_context_.GetRequestContext()->CreateRequest(
             extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
             &test_delegate_));
     StartRequest(request.get(), content::RESOURCE_TYPE_MEDIA);
     EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
@@ skipping 22 matching lines @@
             DoRequest(*extension, relative_path.AsUTF8Unsafe()));
 
   // Loading "/_metadata/a.txt" should also fail.
   relative_path = base::FilePath(kMetadataFolder).AppendASCII("a.txt");
   EXPECT_TRUE(base::PathExists(extension_dir.Append(relative_path)));
   EXPECT_EQ(net::URLRequestStatus::FAILED,
             DoRequest(*extension, relative_path.AsUTF8Unsafe()));
 }
 
 }  // namespace extensions