ui/events/base_event_utils.h - Issue 2007083002: Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/base_event_utils.h

Issue 2007083002: Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@453559-use-timeticks-ui-event

Patch Set: Fix macOS test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_mac_unittest.mm ('K') | « ui/chromeos/ui_chromeos.gyp ('k') | ui/events/base_event_utils.cc » ('j') | ui/events/test/event_generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/base_event_utils.h

diff --git a/ui/events/base_event_utils.h b/ui/events/base_event_utils.h

index 74902516029ee8af5503075414fb485aa68b18d8..c70e70ead0648525bbc86d3ed96b4e8a5044f1be 100644

--- a/ui/events/base_event_utils.h

+++ b/ui/events/base_event_utils.h

@@ -6,7 +6,9 @@

#define UI_EVENTS_BASE_EVENT_UTILS_H_

#include <stdint.h>

+#include <memory>

sadrul 2016/06/23 16:38:37 sort

majidvp 2016/06/24 19:40:56 Done.

+#include "base/time/tick_clock.h"

#include "ui/events/events_base_export.h"

namespace base {

@@ -22,6 +24,12 @@ EVENTS_BASE_EXPORT uint32_t GetNextTouchEventId();

// Checks if |flags| contains system key modifiers.

EVENTS_BASE_EXPORT bool IsSystemKeyModifier(int flags);

+// Create a timestamp based on the current time.

+EVENTS_BASE_EXPORT base::TimeTicks EventTimeForNow();

+EVENTS_BASE_EXPORT void SetEventTickClockForTesting(

+ std::unique_ptr<base::TickClock> tick_clock);

// Converts an event timestamp ticks to seconds (floating point representation).

// WARNING: This should only be used when interfacing with platform code that

// does not use base::Time* types.