components/tracing/graphics_memory_dump_provider_android_unittest.cc - Issue 2006943003: [tracing] Sanitize process memory dumps for background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/graphics_memory_dump_provider_android_unittest.cc

Issue 2006943003: [tracing] Sanitize process memory dumps for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp

Patch Set: Fixes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/process_memory_dump_unittest.cc ('K') | « base/trace_event/winheap_dump_provider_win_unittest.cc ('k') | components/tracing/process_metrics_memory_dump_provider_unittest.cc » ('j') | third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/graphics_memory_dump_provider_android_unittest.cc

diff --git a/components/tracing/graphics_memory_dump_provider_android_unittest.cc b/components/tracing/graphics_memory_dump_provider_android_unittest.cc

index 02e9cfd0b1aca07582e6b888e47fb824b39995e8..61329b73b5bb10f1e3918d18af47103e21f75ae0 100644

--- a/components/tracing/graphics_memory_dump_provider_android_unittest.cc

+++ b/components/tracing/graphics_memory_dump_provider_android_unittest.cc

@@ -13,7 +13,8 @@ namespace tracing {

TEST(GraphicsMemoryDumpProviderTest, ParseResponse) {

const char* kDumpBaseName = GraphicsMemoryDumpProvider::kDumpBaseName;

- base::trace_event::ProcessMemoryDump pmd(nullptr);

+ base::trace_event::ProcessMemoryDump pmd(

+ nullptr, {base::trace_event::MemoryDumpLevelOfDetail::DETAILED});

auto instance = GraphicsMemoryDumpProvider::GetInstance();

char buf[] = "graphics_total 12\ngraphics_pss 34\ngl_total 56\ngl_pss 78";

instance->ParseResponseAndAddToDump(buf, strlen(buf), &pmd);