third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp - Issue 2006943003: [tracing] Sanitize process memory dumps for background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

Issue 2006943003: [tracing] Sanitize process memory dumps for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp

Patch Set: Fixes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/process_memory_dump_unittest.cc ('K') | « sql/sql_memory_dump_provider_unittest.cc ('k') | third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

index 83f4a786c2e617c7bba200ffd3173c646feb95d6..794cf74ec6f3d1a82a3d18d5a4be53babdcb59b3 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

@@ -115,7 +115,7 @@ void BlinkGCMemoryDumpProvider::clearProcessDumpForCurrentGC()

}

BlinkGCMemoryDumpProvider::BlinkGCMemoryDumpProvider()

- : m_currentProcessMemoryDump(new base::trace_event::ProcessMemoryDump(nullptr))

+ : m_currentProcessMemoryDump(new base::trace_event::ProcessMemoryDump(nullptr, { base::trace_event::MemoryDumpLevelOfDetail::DETAILED }))

Primiano Tucci (use gerrit) 2016/06/02 20:24:04 OH I wonder if for consistency you should reset m_

ssid 2016/06/03 01:59:47 This dump is added to trace when detailed dump and

, m_isHeapProfilingEnabled(false)

{

}