Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2006703005: Define kInvalidPlatformFile in base (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), jshin+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define kInvalidPlatformFile in base This definition has been duplicated in four different places. Move it to base. BUG=None TBR=jochen@chromium.org for gin Committed: https://crrev.com/5d4213ffbf34aa1c1697f3829e3b023f174b8e8b Cr-Commit-Position: refs/heads/master@{#395952}

Patch Set 1 #

Patch Set 2 : no ppapi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M base/files/file.h View 1 chunk +5 lines, -2 lines 0 comments Download
M base/i18n/icu_util.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M gin/v8_initializer.cc View 6 chunks +6 lines, -13 lines 0 comments Download
M mojo/public/cpp/system/platform_handle.h View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/system/platform_handle.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Ken Rockot(use gerrit already)
Please take a look
4 years, 7 months ago (2016-05-25 17:07:30 UTC) #3
Nico
lgtm
4 years, 7 months ago (2016-05-25 17:10:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006703005/1
4 years, 7 months ago (2016-05-25 17:12:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/175899) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-25 17:25:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006703005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006703005/20001
4 years, 7 months ago (2016-05-25 17:29:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006703005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006703005/20001
4 years, 7 months ago (2016-05-25 17:39:27 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 19:07:24 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 19:09:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d4213ffbf34aa1c1697f3829e3b023f174b8e8b
Cr-Commit-Position: refs/heads/master@{#395952}

Powered by Google App Engine
This is Rietveld 408576698