base/i18n/icu_util.cc - Issue 2006703005: Define kInvalidPlatformFile in base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/icu_util.cc

Issue 2006703005: Define kInvalidPlatformFile in base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no ppapi Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/i18n/icu_util.cc

diff --git a/base/i18n/icu_util.cc b/base/i18n/icu_util.cc

index c85195f06d8ff4657f9ff99f9fc89b1a121d18ba..30876f42f4204480881b575a61fe9863eb90dd70 100644

--- a/base/i18n/icu_util.cc

+++ b/base/i18n/icu_util.cc

@@ -78,12 +78,6 @@ const char kAndroidAssetsIcuDataFileName[] = "assets/icudtl.dat";

// File handle intentionally never closed. Not using File here because its

// Windows implementation guards against two instances owning the same

// PlatformFile (which we allow since we know it is never freed).

-const PlatformFile kInvalidPlatformFile =

-#if defined(OS_WIN)

- INVALID_HANDLE_VALUE;

-#else

- -1;

-#endif

PlatformFile g_icudtl_pf = kInvalidPlatformFile;

MemoryMappedFile* g_icudtl_mapped_file = nullptr;

MemoryMappedFile::Region g_icudtl_region;

« no previous file with comments | « base/files/file.h ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »