Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2006583002: Fix expando-loss-2.html test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add hidden values Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
index a7cfc3896670a4f65b47e5fde6b9d8f8536a7328..67204a9facc19aa68490ebbe714478df25078954 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
@@ -1715,7 +1715,7 @@ GLboolean WebGL2RenderingContextBase::isQuery(WebGLQuery* query)
return contextGL()->IsQueryEXT(query->object());
}
-void WebGL2RenderingContextBase::beginQuery(GLenum target, WebGLQuery* query)
+void WebGL2RenderingContextBase::beginQuery(ScriptState* scriptState, GLenum target, WebGLQuery* query)
{
bool deleted;
if (!query) {
@@ -1764,6 +1764,7 @@ void WebGL2RenderingContextBase::beginQuery(GLenum target, WebGLQuery* query)
query->setTarget(target);
contextGL()->BeginQueryEXT(target, query->object());
+ preserveObjectWrapper(scriptState, this, V8HiddenValue::webglQueries(scriptState->isolate()), &m_queryWrappers, static_cast<uint32_t>(target), query);
}
void WebGL2RenderingContextBase::endQuery(GLenum target)
@@ -1901,7 +1902,7 @@ GLboolean WebGL2RenderingContextBase::isSampler(WebGLSampler* sampler)
return contextGL()->IsSampler(sampler->object());
}
-void WebGL2RenderingContextBase::bindSampler(GLuint unit, WebGLSampler* sampler)
+void WebGL2RenderingContextBase::bindSampler(ScriptState* scriptState, GLuint unit, WebGLSampler* sampler)
{
if (isContextLost())
return;
@@ -1922,6 +1923,8 @@ void WebGL2RenderingContextBase::bindSampler(GLuint unit, WebGLSampler* sampler)
m_samplerUnits[unit] = sampler;
contextGL()->BindSampler(unit, objectOrZero(sampler));
+
+ preserveObjectWrapper(scriptState, this, V8HiddenValue::webglSamplers(scriptState->isolate()), &m_samplerWrappers, static_cast<uint32_t>(unit), sampler);
}
void WebGL2RenderingContextBase::samplerParameter(WebGLSampler* sampler, GLenum pname, GLfloat paramf, GLint parami, bool isFloat)
@@ -2155,7 +2158,7 @@ GLboolean WebGL2RenderingContextBase::isTransformFeedback(WebGLTransformFeedback
return contextGL()->IsTransformFeedback(feedback->object());
}
-void WebGL2RenderingContextBase::bindTransformFeedback(GLenum target, WebGLTransformFeedback* feedback)
+void WebGL2RenderingContextBase::bindTransformFeedback(ScriptState* scriptState, GLenum target, WebGLTransformFeedback* feedback)
{
bool deleted;
if (!checkObjectToBeBound("bindTransformFeedback", feedback, deleted))
@@ -2178,8 +2181,11 @@ void WebGL2RenderingContextBase::bindTransformFeedback(GLenum target, WebGLTrans
m_transformFeedbackBinding = feedback;
contextGL()->BindTransformFeedback(target, objectOrZero(feedback));
- if (feedback)
+ if (feedback) {
feedback->setTarget(target);
+ preserveObjectWrapper(scriptState, this, V8HiddenValue::webglMisc(scriptState->isolate()), &m_miscWrappers, static_cast<uint32_t>(PreservedTransformFeedback), feedback);
+ }
+
}
void WebGL2RenderingContextBase::beginTransformFeedback(GLenum primitiveMode)

Powered by Google App Engine
This is Rietveld 408576698