Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2006273003: Worker: Make WorkerMicrotaskRunner a private inner class of WorkerThread (Closed)

Created:
4 years, 7 months ago by nhiroki
Modified:
4 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Make WorkerMicrotaskRunner a private inner class of WorkerThread This CL makes WorkerMicrotaskRunner a private inner class of WorkerThread because the task runner is basically used only from WorkerThread and it needs to access a function of WorkerThread that is currently public but should be private. This also renames performShutdownTask() to performShutdown() for improving naming consistency with prepareForShutdown(). This should not change any behavior. BUG=487050, 575532 Committed: https://crrev.com/890dd5caf4fd966ad59b219b53c9141b4a7399a1 Cr-Commit-Position: refs/heads/master@{#395817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 4 chunks +19 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
nhiroki
PTAL, thanks!
4 years, 7 months ago (2016-05-25 01:44:42 UTC) #7
kinuko
lgtm
4 years, 7 months ago (2016-05-25 06:53:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006273003/1
4 years, 7 months ago (2016-05-25 06:55:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 06:59:31 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 07:01:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/890dd5caf4fd966ad59b219b53c9141b4a7399a1
Cr-Commit-Position: refs/heads/master@{#395817}

Powered by Google App Engine
This is Rietveld 408576698