Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2006153002: Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #8 id:140001 of https://codereview.chromium.org/1984873002/ ) Reason for revert: Depending on an implementation still in review. Results in flooding of LOG messages. https://bugs.chromium.org/p/chromium/issues/detail?id=614155 https://codereview.chromium.org/1993333002/ Original issue's description: > Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. > > The new logic will hold onto GpuMemoryBuffer Resources until they are no longer > in use by the Window Server. > > BUG=608026 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/87aa976eacd8ed0c530d32a7c85d6ba706dcabf6 > Cr-Commit-Position: refs/heads/master@{#395150} TBR=ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608026 Committed: https://crrev.com/aa5126ff66379a9060e87b010135f1aee7fc1ab2 Cr-Commit-Position: refs/heads/master@{#395524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -60 lines) Patch
M cc/output/gl_renderer.h View 1 chunk +3 lines, -12 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +14 lines, -41 lines 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
erikchen
Created Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources.
4 years, 7 months ago (2016-05-23 23:44:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-23 23:45:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-24 00:02:27 UTC) #3
ccameron
On 2016/05/24 00:02:27, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-24 00:27:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-24 00:31:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-24 01:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-24 01:31:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-24 02:02:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006153002/1
4 years, 7 months ago (2016-05-24 02:31:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 03:00:02 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa5126ff66379a9060e87b010135f1aee7fc1ab2 Cr-Commit-Position: refs/heads/master@{#395524}
4 years, 7 months ago (2016-05-24 03:02:26 UTC) #13
ccameron
4 years, 7 months ago (2016-05-26 17:25:04 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2015923003/ by ccameron@chromium.org.

The reason for reverting is: The patch that this depended on,
https://codereview.chromium.org/1993333002/, has landed..

Powered by Google App Engine
This is Rietveld 408576698