Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2006143004: [Devtools] Proper filter set from panel jump into network panel (Closed)

Created:
4 years, 7 months ago by allada
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Proper filter set from panel jump into network panel Made it so when link is clicked that jumps and pre-filters results in the network panel it now properly adjusts regex and other filters. BUG=609441 R=lushnikov Committed: https://crrev.com/cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab Cr-Commit-Position: refs/heads/master@{#396383}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
allada
PTL
4 years, 7 months ago (2016-05-24 21:49:13 UTC) #1
lushnikov
https://codereview.chromium.org/2006143004/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2006143004/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1060 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1060: setTextFilterValue: function(filterString) Let's make this method reset regexChecked checkbox ...
4 years, 7 months ago (2016-05-24 22:50:36 UTC) #2
allada
PTL https://codereview.chromium.org/2006143004/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2006143004/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1060 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1060: setTextFilterValue: function(filterString) On 2016/05/24 22:50:36, lushnikov wrote: > ...
4 years, 7 months ago (2016-05-26 21:33:07 UTC) #3
lushnikov
lgtm
4 years, 7 months ago (2016-05-26 23:25:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006143004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006143004/20001
4 years, 7 months ago (2016-05-26 23:29:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-27 01:32:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006143004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006143004/20001
4 years, 7 months ago (2016-05-27 03:17:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-27 04:35:50 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 04:37:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab
Cr-Commit-Position: refs/heads/master@{#396383}

Powered by Google App Engine
This is Rietveld 408576698