Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 2006143004: [Devtools] Proper filter set from panel jump into network panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
index 3ff751863e57e9a88c1dd0786d697e56fc1dcb41..d4f692f2b262a640579e2213d4e71060a939d31c 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
@@ -290,6 +290,15 @@ WebInspector.TextFilterUI.prototype = {
},
/**
+ * @param {boolean} checked
+ */
+ setRegexChecked: function(checked)
+ {
+ if (this._supportRegex)
+ this._regexCheckBox.checked = checked;
+ },
+
+ /**
* @return {?RegExp}
*/
regex: function()
@@ -503,7 +512,7 @@ WebInspector.NamedBitSetFilterUI = function(items, setting)
setting.addChangeListener(this._settingChanged.bind(this));
this._settingChanged();
} else {
- this._toggleTypeFilter(WebInspector.NamedBitSetFilterUI.ALL_TYPES, false);
+ this._toggleTypeFilter(WebInspector.NamedBitSetFilterUI.ALL_TYPES, false /* allowMultiSelect */);
}
}
@@ -513,6 +522,11 @@ WebInspector.NamedBitSetFilterUI.Item;
WebInspector.NamedBitSetFilterUI.ALL_TYPES = "all";
WebInspector.NamedBitSetFilterUI.prototype = {
+ reset: function()
+ {
+ this._toggleTypeFilter(WebInspector.NamedBitSetFilterUI.ALL_TYPES, false /* allowMultiSelect */);
+ },
+
/**
* @override
* @return {boolean}
@@ -736,6 +750,14 @@ WebInspector.CheckboxFilterUI.prototype = {
},
/**
+ * @param {boolean} checked
+ */
+ setChecked: function(checked)
+ {
+ this._checkboxElement.checked = checked;
+ },
+
+ /**
* @override
* @return {!Element}
*/
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698