Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2006093004: Motown: Convert MediaSink to expose MediaTimelineControlSite (Closed)

Created:
4 years, 7 months ago by dalesat
Modified:
4 years, 7 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Convert MediaSink to expose MediaTimelineControlSite 1) Remove play/pause and status from MediaSink. 2) Support GetTimelineControlSite on MediaSink so player has access to the MediaTimelineControlSite on the underlying renderer. 3) Remove unneeded MediaState in favor of the current transform and an end-of-stream indication. 4) Make AudioTrack report end-of-stream (by way of TimelineControlSite), removing this logic from the MediaProducer. 5) Eliminate unneeded logic from MediaProducer now that timeline control no longer requires packet PTS. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8f792ddc84935f637bfdde2c87980d8d3e3c874c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -2220 lines) Patch
M examples/media_test/media_test.h View 3 chunks +6 lines, -4 lines 0 comments Download
M examples/media_test/media_test.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M examples/media_test/media_test_app.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M mojo/dart/packages/mojo_services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_track.mojom.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart View 5 chunks +10 lines, -15 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_sink.mojom.dart View 11 chunks +25 lines, -398 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_source.mojom.dart View 5 chunks +3 lines, -22 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/media/media_state.mojom.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/media/rate_control.mojom.dart View 1 chunk +0 lines, -1235 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/timeline_controller.mojom.dart View 3 chunks +42 lines, -4 lines 0 comments Download
M mojo/services/media/common/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/media/common/interfaces/media_state.mojom View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/services/media/common/interfaces/timelines.mojom View 1 chunk +9 lines, -6 lines 0 comments Download
M mojo/services/media/control/interfaces/media_player.mojom View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/services/media/control/interfaces/media_sink.mojom View 2 chunks +3 lines, -29 lines 0 comments Download
M mojo/services/media/control/interfaces/media_source.mojom View 2 chunks +0 lines, -5 lines 0 comments Download
M services/media/audio/audio_pipe.h View 3 chunks +7 lines, -2 lines 0 comments Download
M services/media/audio/audio_pipe.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M services/media/audio/audio_track_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M services/media/common/timeline_control_site.h View 3 chunks +8 lines, -0 lines 0 comments Download
M services/media/common/timeline_control_site.cc View 3 chunks +30 lines, -1 line 0 comments Download
M services/media/factory_service/audio_track_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M services/media/factory_service/audio_track_controller.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M services/media/factory_service/media_player_impl.h View 5 chunks +32 lines, -28 lines 0 comments Download
M services/media/factory_service/media_player_impl.cc View 8 chunks +94 lines, -118 lines 0 comments Download
M services/media/factory_service/media_sink_impl.h View 3 chunks +3 lines, -20 lines 0 comments Download
M services/media/factory_service/media_sink_impl.cc View 5 chunks +16 lines, -110 lines 0 comments Download
M services/media/factory_service/media_source_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/media/factory_service/media_source_impl.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M services/media/framework_mojo/mojo_formatting.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/media/framework_mojo/mojo_formatting.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M services/media/framework_mojo/mojo_producer.h View 4 chunks +0 lines, -15 lines 0 comments Download
M services/media/framework_mojo/mojo_producer.cc View 6 chunks +1 line, -37 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 7 months ago (2016-05-24 19:42:48 UTC) #3
kulakowski
lgtm https://codereview.chromium.org/2006093004/diff/1/services/media/framework_mojo/mojo_producer.cc File services/media/framework_mojo/mojo_producer.cc (right): https://codereview.chromium.org/2006093004/diff/1/services/media/framework_mojo/mojo_producer.cc#newcode83 services/media/framework_mojo/mojo_producer.cc:83: base::AutoLock lock(lock_); I don't think you need to ...
4 years, 7 months ago (2016-05-24 20:27:52 UTC) #4
dalesat
4 years, 7 months ago (2016-05-24 21:37:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f792ddc84935f637bfdde2c87980d8d3e3c874c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698