Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: services/media/factory_service/media_source_impl.cc

Issue 2006093004: Motown: Convert MediaSink to expose MediaTimelineControlSite (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/media/factory_service/media_source_impl.cc
diff --git a/services/media/factory_service/media_source_impl.cc b/services/media/factory_service/media_source_impl.cc
index 10311bc4cc327de9fe343fb72d38602fdd8424a8..c2e38db7a5edd131ba8b9694c92ebd682e8d54e4 100644
--- a/services/media/factory_service/media_source_impl.cc
+++ b/services/media/factory_service/media_source_impl.cc
@@ -41,7 +41,6 @@ MediaSourceImpl::MediaSourceImpl(
status_publisher_.SetCallbackRunner(
[this](const GetStatusCallback& callback, uint64_t version) {
MediaSourceStatusPtr status = MediaSourceStatus::New();
- status->state = state_;
status->metadata =
demux_ ? MediaMetadata::From(demux_->metadata()) : nullptr;
callback.Run(version, status.Pass());
@@ -49,15 +48,15 @@ MediaSourceImpl::MediaSourceImpl(
std::shared_ptr<Reader> reader_ptr = MojoReader::Create(reader.Pass());
if (!reader_ptr) {
- NOTREACHED() << "couldn't create reader";
- state_ = MediaState::FAULT;
+ LOG(ERROR) << "couldn't create reader";
+ // TODO(dalesat): Add problem reporting.
return;
}
demux_ = Demux::Create(reader_ptr);
if (!demux_) {
- NOTREACHED() << "couldn't create demux";
- state_ = MediaState::FAULT;
+ LOG(ERROR) << "couldn't create demux";
+ // TODO(dalesat): Add problem reporting.
return;
}
@@ -138,7 +137,6 @@ void MediaSourceImpl::Prepare(const PrepareCallback& callback) {
stream->EnsureSink();
}
graph_.Prepare();
- state_ = MediaState::PAUSED;
callback.Run();
status_publisher_.SendUpdates();
}

Powered by Google App Engine
This is Rietveld 408576698