third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach.html - Issue 2006033002: Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach.html

Issue 2006033002: Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: -Wild idea, +test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/navigation/start-load-during-provisional-loader-detach-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <body>

	2 We pass if we don't crash.

	3 <script>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6

	7 var child = document.body.appendChild(document.createElement('iframe'));

	8 child.contentDocument.open();

	9 var grandchild = child.contentDocument.appendChild(document.createElement('ifram e'));

	10

	11 child.contentWindow.onload = function() {
	Nate Chapin 2016/05/25 23:03:08 This test fails without the FrameLoader.cpp change This test fails without the FrameLoader.cpp change by crashing in FrameLoader::commitProvisionalLoad due to m_provisionalDocumentLoader being null. The repro in the bug calls stop(), but that makes the test a lot more complicated to run automatically: it requires a waitUntilDone(), and there isn't a place to call notifyDone() that works both with and without the bugfix.
	12 var a = grandchild.contentDocument.createElement('a');

	13 a.href = 'data:text/xml,';

	14 a.click();

	15 }

	16

	17 var a = grandchild.contentDocument.createElement('a');

	18 a.href = 'data:text/xml,';

	19 a.click();

	20

	21 child.contentDocument.close();

	22

	23 a = grandchild.contentDocument.createElement('a');

	24 a.href = 'data:text/html,';

	25 a.click();

	26 </script>

	27 </body>

OLD	NEW