chrome/browser/prefs/pref_metrics_service.cc - Issue 2006023002: Log some information about the state of the homepage on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_metrics_service.cc

Issue 2006023002: Log some information about the state of the homepage on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not log homepage stats natively as it does not apply to Android. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_metrics_service.cc

diff --git a/chrome/browser/prefs/pref_metrics_service.cc b/chrome/browser/prefs/pref_metrics_service.cc

index 54ee8505c59947eac378c7a6405f4ee6d2532bc2..96241e65fface65d7f8a2b8d0f20a2f88c5fb13b 100644

--- a/chrome/browser/prefs/pref_metrics_service.cc

+++ b/chrome/browser/prefs/pref_metrics_service.cc

@@ -79,6 +79,7 @@ PrefMetricsService::~PrefMetricsService() {

}

void PrefMetricsService::RecordLaunchPrefs() {

+#if !defined(OS_ANDROID)

bool show_home_button = prefs_->GetBoolean(prefs::kShowHomeButton);

bool home_page_is_ntp = prefs_->GetBoolean(prefs::kHomePageIsNewTabPage);

UMA_HISTOGRAM_BOOLEAN("Settings.ShowHomeButton", show_home_button);

@@ -106,6 +107,7 @@ void PrefMetricsService::RecordLaunchPrefs() {

homepage_url);

}

+#endif

SampleNewTabPageURL(profile_);

Mark P 2016/05/24 04:31:26 Is this appropriate for Android? (chrome::kChrome

Ted C 2016/05/24 16:53:15 We don't allow overriding the new tab URL on Andro