Log some information about the state of the homepage on Android.

chrome/browser/prefs/pref_metrics_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_metrics_service.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 61 matching lines @@
     : profile_(profile),
       prefs_(profile->GetPrefs()),
       local_state_(local_state),
       weak_factory_(this) {
 }
 
 PrefMetricsService::~PrefMetricsService() {
 }
 
 void PrefMetricsService::RecordLaunchPrefs() {
+#if !defined(OS_ANDROID)
   bool show_home_button = prefs_->GetBoolean(prefs::kShowHomeButton);
   bool home_page_is_ntp = prefs_->GetBoolean(prefs::kHomePageIsNewTabPage);
   UMA_HISTOGRAM_BOOLEAN("Settings.ShowHomeButton", show_home_button);
   if (show_home_button) {
     UMA_HISTOGRAM_BOOLEAN("Settings.GivenShowHomeButton_HomePageIsNewTabPage",
                           home_page_is_ntp);
   }
 
   // For non-NTP homepages, see if the URL comes from the same TLD+1 as a known
   // search engine.  Note that this is only an approximation of search engine
   // use, due to both false negatives (pages that come from unknown TLD+1 X but
   // consist of a search box that sends to known TLD+1 Y) and false positives
   // (pages that share a TLD+1 with a known engine but aren't actually search
   // pages, e.g. plus.google.com).  Additionally, record the TLD+1 of non-NTP
   // homepages through the privacy-preserving Rappor service.
   if (!home_page_is_ntp) {
     GURL homepage_url(prefs_->GetString(prefs::kHomePage));
     if (homepage_url.is_valid()) {
       UMA_HISTOGRAM_ENUMERATION(
           "Settings.HomePageEngineType",
           TemplateURLPrepopulateData::GetEngineType(homepage_url),
           SEARCH_ENGINE_MAX);
       rappor::SampleDomainAndRegistryFromGURL(
           g_browser_process->rappor_service(), "Settings.HomePage2",
           homepage_url);
     }
   }
+#endif
 
   SampleNewTabPageURL(profile_);

[Mark P, 2016/05/24 04:31:26]

Is this appropriate for Android?  (chrome::kChromeUINewTabURL)

[Ted C, 2016/05/24 16:53:15]

We don't allow overriding the new tab URL on Android.

 
   int restore_on_startup = prefs_->GetInteger(prefs::kRestoreOnStartup);

[Mark P, 2016/05/24 04:31:26]

And this whole block here for that matter?

[Ted C, 2016/05/24 16:53:15]

We also don't use desktop restore either, but I'm not entirely sure what this
following block does.

To me, it looks like neither of these apply on Android.

   UMA_HISTOGRAM_ENUMERATION("Settings.StartupPageLoadSettings",
                             restore_on_startup, kSessionStartupPrefValueMax);
   if (restore_on_startup == SessionStartupPref::kPrefValueURLs) {
     const base::ListValue* url_list =
         prefs_->GetList(prefs::kURLsToRestoreOnStartup);
     UMA_HISTOGRAM_CUSTOM_COUNTS("Settings.StartupPageLoadURLs",
                                 url_list->GetSize(), 1, 50, 20);
     // Similarly, check startup pages for known search engine TLD+1s.
     std::string url_text;
     for (size_t i = 0; i < url_list->GetSize(); ++i) {
@@ skipping 126 matching lines @@
 }
 
 bool PrefMetricsService::Factory::ServiceIsNULLWhileTesting() const {
   return false;
 }
 
 content::BrowserContext* PrefMetricsService::Factory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }