Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/extension_web_contents_observer.h

Issue 2006013002: [Extensions] Determine NativeMessaging ID solely on the browser process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ;; Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_web_contents_observer.h
diff --git a/extensions/browser/extension_web_contents_observer.h b/extensions/browser/extension_web_contents_observer.h
index 5b86dc08eba0b687f6c25acc39563af6dfce647a..2c15333c47dc1172bb1acd22099e46c43491341d 100644
--- a/extensions/browser/extension_web_contents_observer.h
+++ b/extensions/browser/extension_web_contents_observer.h
@@ -56,6 +56,15 @@ class ExtensionWebContentsObserver
ExtensionFunctionDispatcher* dispatcher() { return &dispatcher_; }
+ // Returns the extension associated with the given |render_frame_host|, or
+ // null if there is none.
+ // If |verify_url| is false, only the SiteInstance is taken into account.
+ // If |verify_url| is true, the frame's last committed URL is also used to
+ // improve the classification of the frame.
+ const Extension* GetExtensionFromFrame(
+ content::RenderFrameHost* render_frame_host,
+ bool verify_url) const;
+
protected:
explicit ExtensionWebContentsObserver(content::WebContents* web_contents);
~ExtensionWebContentsObserver() override;
@@ -99,15 +108,6 @@ class ExtensionWebContentsObserver
std::string GetExtensionIdFromFrame(
content::RenderFrameHost* render_frame_host) const;
- // Returns the extension associated with the given |render_frame_host|, or
- // null if there is none.
- // If |verify_url| is false, only the SiteInstance is taken into account.
- // If |verify_url| is true, the frame's last committed URL is also used to
- // improve the classification of the frame.
- const Extension* GetExtensionFromFrame(
- content::RenderFrameHost* render_frame_host,
- bool verify_url) const;
-
// TODO(devlin): Remove these once callers are updated to use the FromFrame
// equivalents.
// Returns the extension or app associated with a render view host. Returns
« no previous file with comments | « chrome/browser/renderer_host/chrome_extension_message_filter.cc ('k') | extensions/common/extension_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698