Make the object store visible in Observatory.

Make the object store visible in Observatory.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/2eb84089698465ecd0fa133c5331a69088fc86fa

[rmacnak, 2016-05-23 20:27:54]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-05-24 14:34:40]

This CL appears to be missing the new files. I've left a comment about the ids
used for object store instances.

https://codereview.chromium.org/2005983002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2005983002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:3596: JSONObject jsobj(js);
Could we use stable ids for objects in the object store?

[rmacnak, 2016-05-24 16:31:38]

Added missing files.

https://codereview.chromium.org/2005983002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2005983002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:3596: JSONObject jsobj(js);
On 2016/05/24 14:34:40, Cutch wrote:
> Could we use stable ids for objects in the object store?

Not all of them. Many of the cache fields of the object store are reassigned
when the cache grows. The immutable fields are mostly known classes or libraries
that already have stable ids, so it don't think it is worth curating a list of
immutable fields in the object store and checking every object to see if it is
in one of those slots before giving it a ring id.

[Cutch, 2016-05-25 17:44:27]

lgtm

[rmacnak, 2016-05-25 18:12:35]

Description was changed from

==========
Make the object store visible in Observatory.
==========

to

==========
Make the object store visible in Observatory.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2eb84089698465ecd0fa133c5331a69088fc86fa
==========

[rmacnak, 2016-05-25 18:12:37]

Committed patchset #3 (id:40001) manually as
2eb84089698465ecd0fa133c5331a69088fc86fa (presubmit successful).