Make the object store visible in Observatory.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/globals.h"
 
@@ skipping 3574 matching lines @@
   // Handle non-heap objects.
   Breakpoint* bpt = LookupBreakpoint(thread->isolate(), id, &lookup_result);
   if (bpt != NULL) {
     bpt->PrintJSON(js);
     return true;
   } else if (lookup_result == ObjectIdRing::kCollected) {
     PrintSentinel(js, kCollectedSentinel);
     return true;
   }
 
+  if (strcmp(id, "object_store") == 0) {
+    JSONObject jsobj(js);

[Cutch, 2016/05/24 14:34:40]

Could we use stable ids for objects in the object store?

[rmacnak, 2016/05/24 16:31:38]

Not all of them. Many of the cache fields of the object store are reassigned
when the cache grows. The immutable fields are mostly known classes or libraries
that already have stable ids, so it don't think it is worth curating a list of
immutable fields in the object store and checking every object to see if it is
in one of those slots before giving it a ring id.

+    thread->isolate()->object_store()->PrintToJSONObject(&jsobj, false);
+    return true;
+  }
+
   PrintInvalidParamError(js, "objectId");
   return true;
 }
 
 
 static const MethodParameter* get_class_list_params[] = {
   RUNNABLE_ISOLATE_PARAMETER,
   NULL,
 };
 
@@ skipping 437 matching lines @@
     if (strcmp(method_name, method.name) == 0) {
       return &method;
     }
   }
   return NULL;
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart