Convert collapsed border repaint tests to reftests

Convert collapsed border repaint tests to reftests

This is to let the tests also cover painting.

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
Committed: https://crrev.com/146cc8b651a16957243076699a90825ca80dee7a
Cr-Commit-Position: refs/heads/master@{#395751}

[Xianzhu, 2016-05-23 19:01:11]

wangxianzhu@chromium.org changed reviewers:
+ dgrogan@chromium.org

[Xianzhu, 2016-05-24 16:31:19]

Description was changed from

==========
Convert collapsed border repaint tests to reftests

BUG=611462
==========

to

==========
Convert collapsed border repaint tests to reftests

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
==========

[Xianzhu, 2016-05-24 16:34:22]

PTAL.

The diffs shown might look confusing because of the 'git cl's behavior
of finding similar files. You can ignore the diffs shown, just look at
if the new references are correct for the tests.

Summary of the CL:

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

[dgrogan, 2016-05-24 22:50:27]

lgtm

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html
(right):

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html:13:
document.getElementById("foo").style.borderColor = "lime";
This line is unnecessary?

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html
(right):

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html:13:
<table style="border-collapse:collapse; border:2px solid blue; position:
relative;">
I know that position:relative gives this node its own paint layer but I don't
know why that's needed here. I trust that you do :)

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html:22:

Extra whitespace?

[Xianzhu, 2016-05-24 23:13:28]

Description was changed from

==========
Convert collapsed border repaint tests to reftests

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
==========

to

==========
Convert collapsed border repaint tests to reftests

This is to let the tests also cover painting.

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
==========

[Xianzhu, 2016-05-24 23:13:41]

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html
(right):

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html:13:
document.getElementById("foo").style.borderColor = "lime";
On 2016/05/24 22:50:27, dgrogan wrote:
> This line is unnecessary?

Done.

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html
(right):

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html:13:
<table style="border-collapse:collapse; border:2px solid blue; position:
relative;">
On 2016/05/24 22:50:27, dgrogan wrote:
> I know that position:relative gives this node its own paint layer but I don't
> know why that's needed here. I trust that you do :)

It's needed to produce the same layout as the test which also has this.
What you see on the left is actually has nothing to do this this file, just
chosen because it contains some similar lines to this file :)

https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html:22:

On 2016/05/24 22:50:27, dgrogan wrote:
> Extra whitespace?

Done.

[Xianzhu, 2016-05-24 23:13:54]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-05-24 23:13:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dgrogan@chromium.org
Link to the patchset: https://codereview.chromium.org/2005553002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-24 23:14:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005553002/60001

[dgrogan, 2016-05-24 23:51:24]

Shoot, now I get

$ run-webkit-tests --disable-breakpad --debug --clobber-old-results
--no-retry-failures
fast/table/border-collapsing/cached-change-tbody-border-width.html
[snip]
fast/table/border-collapsing/cached-change-tbody-border-width.html is a reftest,
but has an unused expectation file. Please remove
/src/chrome/5/src/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png.

[Xianzhu, 2016-05-24 23:55:21]

On 2016/05/24 23:51:24, dgrogan wrote:
> Shoot, now I get
> 
> $ run-webkit-tests --disable-breakpad --debug --clobber-old-results
> --no-retry-failures
> fast/table/border-collapsing/cached-change-tbody-border-width.html
> [snip]
> fast/table/border-collapsing/cached-change-tbody-border-width.html is a
reftest,
> but has an unused expectation file. Please remove
>
/src/chrome/5/src/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png.

No worries. This patch removes the extra pixel expectations.

[dgrogan, 2016-05-24 23:56:29]

Oh right, I deleted the png parts of the diff b/c git cl patch doesn't handle
them well. Don't know how I forgot I did that :(

[commit-bot: I haz the power, 2016-05-25 00:30:15]

Description was changed from

==========
Convert collapsed border repaint tests to reftests

This is to let the tests also cover painting.

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
==========

to

==========
Convert collapsed border repaint tests to reftests

This is to let the tests also cover painting.

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
==========

[commit-bot: I haz the power, 2016-05-25 00:30:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 00:31:56]

Description was changed from

==========
Convert collapsed border repaint tests to reftests

This is to let the tests also cover painting.

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462
==========

to

==========
Convert collapsed border repaint tests to reftests

This is to let the tests also cover painting.

- Change runRepaintTest() to runRepaintAndPixelTest() in the tests to
  let them generate pixel results for ref testing;

- Create reference expectations based on the tests by setting the dom
  and styles to the final state of the tests;

- Removed extra png expectations which were not used.

BUG=611462

Committed: https://crrev.com/146cc8b651a16957243076699a90825ca80dee7a
Cr-Commit-Position: refs/heads/master@{#395751}
==========

[commit-bot: I haz the power, 2016-05-25 00:31:57]

Patchset 4 (id:??) landed as
https://crrev.com/146cc8b651a16957243076699a90825ca80dee7a
Cr-Commit-Position: refs/heads/master@{#395751}