Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2005553002: Convert collapsed border repaint tests to reftests (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert collapsed border repaint tests to reftests This is to let the tests also cover painting. - Change runRepaintTest() to runRepaintAndPixelTest() in the tests to let them generate pixel results for ref testing; - Create reference expectations based on the tests by setting the dom and styles to the final state of the tests; - Removed extra png expectations which were not used. BUG=611462 Committed: https://crrev.com/146cc8b651a16957243076699a90825ca80dee7a Cr-Commit-Position: refs/heads/master@{#395751}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -93 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-69296.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-69296-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-append.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-append-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-remove.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-remove-expected.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-remove-expected.txt View 1 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-color-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-col-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-col-border-color-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-col-border-width.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-col-border-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-width.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-row-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-row-border-color-expected.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-row-border-color-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-table-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-table-border-color-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-table-border-width.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-table-border-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-color.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-color-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-69296-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-cell-append-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-cell-remove-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-col-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-col-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-table-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-table-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-69296-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-cell-append-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-cell-remove-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-cell-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-cell-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-col-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-col-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-row-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-table-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-table-border-width-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png View 1 Binary file 0 comments Download

Messages

Total messages: 17 (7 generated)
Xianzhu
4 years, 7 months ago (2016-05-23 19:01:12 UTC) #2
Xianzhu
PTAL. The diffs shown might look confusing because of the 'git cl's behavior of finding ...
4 years, 7 months ago (2016-05-24 16:34:22 UTC) #4
dgrogan
lgtm https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html File third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html (right): https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html#newcode13 third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html:13: document.getElementById("foo").style.borderColor = "lime"; This line is unnecessary? https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html ...
4 years, 7 months ago (2016-05-24 22:50:27 UTC) #5
Xianzhu
https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html File third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html (right): https://codereview.chromium.org/2005553002/diff/40001/third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html#newcode13 third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html:13: document.getElementById("foo").style.borderColor = "lime"; On 2016/05/24 22:50:27, dgrogan wrote: > ...
4 years, 7 months ago (2016-05-24 23:13:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005553002/60001
4 years, 7 months ago (2016-05-24 23:14:35 UTC) #10
dgrogan
Shoot, now I get $ run-webkit-tests --disable-breakpad --debug --clobber-old-results --no-retry-failures fast/table/border-collapsing/cached-change-tbody-border-width.html [snip] fast/table/border-collapsing/cached-change-tbody-border-width.html is a ...
4 years, 7 months ago (2016-05-24 23:51:24 UTC) #11
Xianzhu
On 2016/05/24 23:51:24, dgrogan wrote: > Shoot, now I get > > $ run-webkit-tests --disable-breakpad ...
4 years, 7 months ago (2016-05-24 23:55:21 UTC) #12
dgrogan
Oh right, I deleted the png parts of the diff b/c git cl patch doesn't ...
4 years, 7 months ago (2016-05-24 23:56:29 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-25 00:30:16 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:31:57 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/146cc8b651a16957243076699a90825ca80dee7a
Cr-Commit-Position: refs/heads/master@{#395751}

Powered by Google App Engine
This is Rietveld 408576698