third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html - Issue 2005553002: Convert collapsed border repaint tests to reftests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html

Issue 2005553002: Convert collapsed border repaint tests to reftests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-color-expected.html ('k') | third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width-expected.html » ('j') | third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Calculating collapsed borders for big tables is expensive, so we cache them and recalculate when needed.	2 Calculating collapsed borders for big tables is expensive, so we cache them and recalculate when needed.

3 Here we change cell border width, expect that cache is invalidated and paint pro duces expected image.	3 Here we change cell border width, expect that cache is invalidated and paint pro duces expected image.

4 -->	4 -->

5 <html>	5 <html>

6 <head>	6 <head>

7 <title></title>	7 <title></title>

8 <link rel="stylesheet" href="resources/cached.css">	8 <link rel="stylesheet" href="resources/cached.css">

9 <script src="../../../fast/repaint/resources/text-based-repaint.js"></sc ript>	9 <script src="../../../fast/repaint/resources/text-based-repaint.js"></sc ript>

10 <script type="text/javascript">	10 <script type="text/javascript">

11 function repaintTest() {	11 function repaintTest() {

12 document.getElementById("foo").style.borderWidth = "4px";	12 document.getElementById("foo").style.borderWidth = "4px";

13 document.getElementById("foo").style.borderColor = "lime";	13 document.getElementById("foo").style.borderColor = "lime";
	dgrogan 2016/05/24 22:50:27 This line is unnecessary? This line is unnecessary? Xianzhu 2016/05/24 23:13:41 Done. Show quoted text On 2016/05/24 22:50:27, dgrogan wrote: > This line is unnecessary? Done.
14 }	14 }

15 </script>	15 </script>

16 </head>	16 </head>

17 <body onload="runRepaintTest()">	17 <body onload="runRepaintAndPixelTest()">

18 <table style="border-collapse:collapse; border:2px solid blue">	18 <table style="border-collapse:collapse; border:2px solid blue">

19 <tr>	19 <tr>

20 <td style="border:1px solid lime" id="foo"/>	20 <td style="border:1px solid lime" id="foo"/>

21 <td style="border:1px solid black"/>	21 <td style="border:1px solid black"/>

22 </tr>	22 </tr>

23 </table>	23 </table>

24 </body>	24 </body>

25 </html>	25 </html>

26	26

OLD	NEW