Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/bindings/templates/partial_interface.h

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install
Patch Set: Fix multiple definition of signature; addressing nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/partial_interface.h
diff --git a/third_party/WebKit/Source/bindings/templates/partial_interface.h b/third_party/WebKit/Source/bindings/templates/partial_interface.h
index 337b3cc1a89bc30e365c900daf203861d2843726..512cf62539e4f1ae898d15d2a794ba42e543b073 100644
--- a/third_party/WebKit/Source/bindings/templates/partial_interface.h
+++ b/third_party/WebKit/Source/bindings/templates/partial_interface.h
@@ -7,6 +7,9 @@
{% endfor %}
namespace blink {
+{% if attributes|origin_trial_enabled_attributes %}
+class ScriptState;
+{% endif %}
class {{v8_class_or_partial}} {
STATIC_ONLY({{v8_class_or_partial}});
@@ -25,6 +28,9 @@ public:
{% endfor %}
{# Custom internal fields #}
static void preparePrototypeAndInterfaceObject(v8::Local<v8::Context>, const DOMWrapperWorld&, v8::Local<v8::Object>, v8::Local<v8::Function>, v8::Local<v8::FunctionTemplate>);
+ {% for group in attributes|origin_trial_enabled_attributes|groupby('origin_trial_feature_name') %}{{newline}}
+ static void install{{group.grouper}}(ScriptState*, v8::Local<v8::Object> instance);
+ {% endfor %}
private:
static void install{{v8_class}}Template(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::FunctionTemplate> interfaceTemplate);
};

Powered by Google App Engine
This is Rietveld 408576698