third_party/WebKit/Source/bindings/templates/methods.cpp - Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/methods.cpp

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install

Patch Set: Fix multiple definition of signature; addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface_base.cpp ('k') | third_party/WebKit/Source/bindings/templates/partial_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/methods.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/methods.cpp b/third_party/WebKit/Source/bindings/templates/methods.cpp

index 7f109b3f7f624ac62abd2d8522bc5db8a5350291..e4015b153b696bd9f82f7af3c511ef316958324f 100644

--- a/third_party/WebKit/Source/bindings/templates/methods.cpp

+++ b/third_party/WebKit/Source/bindings/templates/methods.cpp

@@ -1,4 +1,4 @@

-{% from 'utilities.cpp' import declare_enum_validation_variable, v8_value_to_local_cpp_value, check_origin_trial %}

+{% from 'utilities.cpp' import declare_enum_validation_variable, v8_value_to_local_cpp_value %}

{##############################################################################}

{% macro generate_method(method, world_suffix) %}

@@ -498,9 +498,6 @@ static void {{method.name}}MethodCallback{{world_suffix}}(const v8::FunctionCall

{% if method.deprecate_as %}

Deprecation::countDeprecationIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{method.deprecate_as}});

{% endif %}

- {% if method.origin_trial_enabled_function %}

- {{check_origin_trial(method) | indent}}

- {% endif %}

{% endif %}{# not method.overloads #}

{% if world_suffix in method.activity_logging_world_list %}

ScriptState* scriptState = ScriptState::from(info.GetIsolate()->GetCurrentContext());