third_party/WebKit/Source/bindings/templates/interface.h - Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install

Patch Set: Fix multiple definition of signature; addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/constants.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.h

diff --git a/third_party/WebKit/Source/bindings/templates/interface.h b/third_party/WebKit/Source/bindings/templates/interface.h

index 36a48b77af2aef6585b9dec94cae274ea3f9094f..a8b4c08e55c7f6ce015747d08fb4779472ca42a7 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.h

+++ b/third_party/WebKit/Source/bindings/templates/interface.h

@@ -11,6 +11,9 @@ namespace blink {

{% if has_event_constructor %}

class Dictionary;

{% endif %}

+{% if attributes|origin_trial_enabled_attributes %}

+class ScriptState;

+{% endif %}

{% if named_constructor %}

class {{v8_class}}Constructor {

STATIC_ONLY({{v8_class}}Constructor);

@@ -165,6 +168,9 @@ public:

{{exported}}static void register{{method.name | blink_capitalize}}MethodForPartialInterface(void (*)(const v8::FunctionCallbackInfo<v8::Value>&));

{% endfor %}

{% endif %}

+ {% for group in attributes|origin_trial_enabled_attributes|groupby('origin_trial_feature_name') %}{{newline}}

+ static void install{{group.grouper}}(ScriptState*, v8::Local<v8::Object> instance);

+ {% endfor %}

{% if has_partial_interface %}

private: