third_party/WebKit/Source/bindings/templates/constants.cpp - Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/constants.cpp

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install

Patch Set: Fix multiple definition of signature; addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/constants.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/constants.cpp b/third_party/WebKit/Source/bindings/templates/constants.cpp

index bc4dac48a1203583f1af567f79a48a0ae094e746..c36323280631961aa70ab020af358242f56e4c2f 100644

--- a/third_party/WebKit/Source/bindings/templates/constants.cpp

+++ b/third_party/WebKit/Source/bindings/templates/constants.cpp

@@ -1,5 +1,3 @@

-{% from 'utilities.cpp' import check_origin_trial %}

{##############################################################################}

{% macro constant_getter_callback(constant) %}

static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info)

@@ -10,9 +8,6 @@ static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v

{% if constant.measure_as %}

UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{constant.measure_as('ConstantGetter')}});

{% endif %}

- {% if constant.origin_trial_enabled_function %}

- {{check_origin_trial(constant) | indent}}

- {% endif %}

{% if constant.idl_type in ('Double', 'Float') %}

v8SetReturnValue(info, {{constant.value}});

{% elif constant.idl_type == 'String' %}