Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 200543005: ConvolverNode.buffer sample rate must match AudioContext rate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webaudio/dom-exceptions.html
diff --git a/LayoutTests/webaudio/dom-exceptions.html b/LayoutTests/webaudio/dom-exceptions.html
index 8cd26a476fd158954c7f53788ca51e0d404017e2..6ea8ca2f6ff0a67c4bb02d403d6fe2f62db8cbd5 100644
--- a/LayoutTests/webaudio/dom-exceptions.html
+++ b/LayoutTests/webaudio/dom-exceptions.html
@@ -165,6 +165,13 @@ function runTest() {
node.connect(context.destination);
shouldThrow("node.gain.exponentialRampToValueAtTime(-1, 0.1)");
shouldThrow("node.gain.exponentialRampToValueAtTime(0, 0.1)");
+
+ // Convolver buffer rate must match context rate. Create on offline context so we
+ // specify the context rate exactly, in case the test is run on platforms with different
+ // HW sample rates.
+ oc = new webkitOfflineAudioContext(1, 44100, 44100);
Ken Russell (switch to Gerrit) 2014/03/14 23:54:12 Possible to get this line into the debug output?
Raymond Toy 2014/03/17 18:09:19 Added as a test so that the expected output contai
+ conv = context.createConvolver();
Ken Russell (switch to Gerrit) 2014/03/14 23:54:12 This isn't referencing "oc". Is it supposed to?
Raymond Toy 2014/03/17 18:09:19 Yes, it should use oc. Fixed.
+ shouldThrow("conv.buffer = context.createBuffer(1, 100, 22050)");
Ken Russell (switch to Gerrit) 2014/03/14 23:54:12 Same here.
Raymond Toy 2014/03/17 18:09:19 Done.
}
runTest();
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698