Chromium Code Reviews Chromium Code Reviews
Issue 200543005:
ConvolverNode.buffer sample rate must match AudioContext rate (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> | 1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <script src="resources/audio-testing.js"></script> | 4 <script src="resources/audio-testing.js"></script> |
| 5 <script src="../resources/js-test.js"></script> | 5 <script src="../resources/js-test.js"></script> |
| 6 <script src="resources/biquad-testing.js"></script> | 6 <script src="resources/biquad-testing.js"></script> |
| 7 </head> | 7 </head> |
| 8 | 8 |
| 9 <body> | 9 <body> |
| 10 | 10 |
| (...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 158 shouldThrow("osc.stop()"); | 158 shouldThrow("osc.stop()"); |
| 159 shouldNotThrow("osc1 = context.createOscillator()"); | 159 shouldNotThrow("osc1 = context.createOscillator()"); |
| 160 shouldNotThrow("osc1.start()"); | 160 shouldNotThrow("osc1.start()"); |
| 161 shouldNotThrow("osc1.stop()"); | 161 shouldNotThrow("osc1.stop()"); |
| 162 | 162 |
| 163 // exponentialRampToValue should throw on non-positive target values. | 163 // exponentialRampToValue should throw on non-positive target values. |
| 164 node = context.createGain(); | 164 node = context.createGain(); |
| 165 node.connect(context.destination); | 165 node.connect(context.destination); |
| 166 shouldThrow("node.gain.exponentialRampToValueAtTime(-1, 0.1)"); | 166 shouldThrow("node.gain.exponentialRampToValueAtTime(-1, 0.1)"); |
| 167 shouldThrow("node.gain.exponentialRampToValueAtTime(0, 0.1)"); | 167 shouldThrow("node.gain.exponentialRampToValueAtTime(0, 0.1)"); |
| 168 | |
| 169 // Convolver buffer rate must match context rate. Create on offline context so we | |
| 170 // specify the context rate exactly, in case the test is run on platforms wi th different | |
| 171 // HW sample rates. | |
| 172 oc = new webkitOfflineAudioContext(1, 44100, 44100); | |
|
Ken Russell (switch to Gerrit)
2014/03/14 23:54:12
Possible to get this line into the debug output?
Raymond Toy
2014/03/17 18:09:19
Added as a test so that the expected output contai
| |
| 173 conv = context.createConvolver(); | |
|
Ken Russell (switch to Gerrit)
2014/03/14 23:54:12
This isn't referencing "oc". Is it supposed to?
Raymond Toy
2014/03/17 18:09:19
Yes, it should use oc. Fixed.
| |
| 174 shouldThrow("conv.buffer = context.createBuffer(1, 100, 22050)"); | |
|
Ken Russell (switch to Gerrit)
2014/03/14 23:54:12
Same here.
Raymond Toy
2014/03/17 18:09:19
Done.
| |
| 168 } | 175 } |
| 169 | 176 |
| 170 runTest(); | 177 runTest(); |
| 171 successfullyParsed = true; | 178 successfullyParsed = true; |
| 172 | 179 |
| 173 </script> | 180 </script> |
| 174 </body> | 181 </body> |
| 175 </html> | 182 </html> |
| OLD | NEW |
