Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: mojom/mojom_tool/serialization/serialization.go

Issue 2005343003: Mojom compiler frontend: Change the type of the |offset| field to uint32. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojom/generated/mojom_types/mojom_types.mojom.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojom/mojom_tool/serialization/serialization.go
diff --git a/mojom/mojom_tool/serialization/serialization.go b/mojom/mojom_tool/serialization/serialization.go
index 2c479714032722de4640b5a4e1785b035a2da3be..c7d10eb5d7b5c1a8d35cdcf89e9ea9675aade40a 100644
--- a/mojom/mojom_tool/serialization/serialization.go
+++ b/mojom/mojom_tool/serialization/serialization.go
@@ -322,9 +322,7 @@ func translateStructField(f *mojom.StructField) (field mojom_types.StructField)
field.DefaultValue = translateDefaultFieldValue(f.DefaultValue)
}
if emitComputedPackingData {
- // TODO(rudominer) Check the allowed size of offsets. The type used in
- // mojom_types.mojom might need to be changed.
- field.Offset = int32(f.Offset())
+ field.Offset = f.Offset()
field.Bit = int8(f.Bit())
field.MinVersion = f.MinVersion()
}
« no previous file with comments | « mojom/generated/mojom_types/mojom_types.mojom.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698