mojom/generated/mojom_types/mojom_types.mojom.go - Issue 2005343003: Mojom compiler frontend: Change the type of the |offset| field to uint32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/generated/mojom_types/mojom_types.mojom.go

Issue 2005343003: Mojom compiler frontend: Change the type of the |offset| field to uint32. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py ('k') | mojom/mojom_tool/serialization/serialization.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojom/generated/mojom_types/mojom_types.mojom.go

diff --git a/mojom/generated/mojom_types/mojom_types.mojom.go b/mojom/generated/mojom_types/mojom_types.mojom.go

index b66e55f4e4a5995ed0b2e40cfcd1fd29e187c7ba..7f58409fdb74f36e4ed42dee2ed6d8974044ead2 100644

--- a/mojom/generated/mojom_types/mojom_types.mojom.go

+++ b/mojom/generated/mojom_types/mojom_types.mojom.go

@@ -459,7 +459,7 @@ type StructField struct {

DeclData *DeclarationData

Type Type

DefaultValue DefaultFieldValue

- Offset int32

+ Offset uint32

Bit int8

MinVersion uint32

}

@@ -490,7 +490,7 @@ func (s *StructField) Encode(encoder *bindings.Encoder) error {

return err

}

- if err := encoder.WriteInt32(s.Offset); err != nil {

+ if err := encoder.WriteUint32(s.Offset); err != nil {

return err

}

if err := encoder.WriteInt8(s.Bit); err != nil {

@@ -560,7 +560,7 @@ func (s *StructField) Decode(decoder *bindings.Decoder) error {

}

if header.ElementsOrVersion >= 0 {

- value0, err := decoder.ReadInt32()

+ value0, err := decoder.ReadUint32()

if err != nil {

return err

}