Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2005313002: Record UMA for Physical Web refresh resolve time (Closed)

Created:
4 years, 7 months ago by cco3
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record UMA for Physical Web refresh resolve time Physical Web Service resolve times are expected to differ based on whether we've recently sent out URLs for resolution, so it makes sense to distinguish between refreshes and non-refresh resolutions in our recorded UMA. BUG=609945 Committed: https://crrev.com/d1a23ec7b4749dfd29903a16c7680e4bcd54d21a Cr-Commit-Position: refs/heads/master@{#396029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java View 4 chunks +13 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
cco3
4 years, 7 months ago (2016-05-24 17:51:05 UTC) #2
mattreynolds
lgtm
4 years, 7 months ago (2016-05-24 17:54:27 UTC) #3
cco3
4 years, 7 months ago (2016-05-24 18:00:23 UTC) #5
rkaplow
lgtm
4 years, 7 months ago (2016-05-25 15:35:06 UTC) #6
nyquist
lgtm
4 years, 7 months ago (2016-05-25 20:23:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005313002/1
4 years, 7 months ago (2016-05-25 20:55:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 23:06:49 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:08:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1a23ec7b4749dfd29903a16c7680e4bcd54d21a
Cr-Commit-Position: refs/heads/master@{#396029}

Powered by Google App Engine
This is Rietveld 408576698