Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

Issue 2005313002: Record UMA for Physical Web refresh resolve time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
index 48fb6b66621164d7d3bd877b53aa61b0e3cb99b9..b1c8de82c884d5d376f88959ffa023b81aa27740 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
@@ -200,13 +200,17 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
super.onStop();
}
- private void resolve(Collection<UrlInfo> urls) {
+ private void resolve(Collection<UrlInfo> urls, final boolean isUserInitiated) {
final long timestamp = SystemClock.elapsedRealtime();
mPwsClient.resolve(urls, new PwsClient.ResolveScanCallback() {
@Override
public void onPwsResults(Collection<PwsResult> pwsResults) {
long duration = SystemClock.elapsedRealtime() - timestamp;
- PhysicalWebUma.onForegroundPwsResolution(ListUrlsActivity.this, duration);
+ if (isUserInitiated) {
+ PhysicalWebUma.onRefreshPwsResolution(ListUrlsActivity.this, duration);
+ } else {
+ PhysicalWebUma.onForegroundPwsResolution(ListUrlsActivity.this, duration);
+ }
// filter out duplicate site URLs.
for (PwsResult pwsResult : pwsResults) {
@@ -247,7 +251,7 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
*/
@Override
public void onDisplayableUrlsAdded(Collection<UrlInfo> urls) {
- resolve(urls);
+ resolve(urls, false);
}
private void startRefresh(boolean isUserInitiated, boolean isSwipeInitiated) {
@@ -285,7 +289,7 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
(AnimationDrawable) mScanningImageView.getDrawable();
animationDrawable.start();
- resolve(urls);
+ resolve(urls, isUserInitiated);
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698