Start untangling the avatar switcher from BrowserNonClientFrameView

Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonManager` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonManager::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonManager

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
Committed: https://crrev.com/1d9cf8afd778e64698fe69e43b9428453ee181d1
Cr-Commit-Position: refs/heads/master@{#370845}

[tapted, 2016-01-19 08:27:23]

Description was changed from

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton: most things
just want a views::View.

BUG=565989
==========

to

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonBridge` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonBridge::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonBridge

The button style enum to avatar_button_style.h so that the details of
NewAvatarButton can be properly encapsulated.

BUG=565989
==========

[tapted, 2016-01-19 08:28:06]

Description was changed from

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonBridge` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonBridge::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonBridge

The button style enum to avatar_button_style.h so that the details of
NewAvatarButton can be properly encapsulated.

BUG=565989
==========

to

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonBridge` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonBridge::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonBridge

The button style enum to avatar_button_style.h so that the details of
NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

[tapted, 2016-01-19 08:28:48]

Description was changed from

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonBridge` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonBridge::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonBridge

The button style enum to avatar_button_style.h so that the details of
NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

to

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonBridge` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonBridge::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonBridge

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

[tapted, 2016-01-20 02:20:00]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-01-20 02:20:01]

Hi sky, please take a look.

(there is a CL that goes the next step -- adding the avatar switcher to
BrowserNonClientFrameView*Mac* -- at http://crrev.com/1529703003 . It also has
the `TODO: move this component down` implemented. It's a tricky refactor though,
and it's hard to find the right balance between sharing and the various
platform/frame-specific layout logic. I think this is a good first step either
way.)

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc (left):

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:382:
chrome::ExecuteCommand(browser_view()->browser(), command);
Mus/Ash had different logic here. Ash is zapped, but Mus will now use the same
logic as Opaque/Glass: picks up GESTURE_LONG_PRESS and goes through a different
codepath, but has the same result.

[sky, 2016-01-20 17:05:36]

Only naming nits

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/avatar_button_bridge.h (right):

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/avatar_button_bridge.h:15: class
AvatarButtonBridge : public views::ButtonListener {
I'm curious why you're naming this with bridge. It doesn't seem at all like the
similarly named classes that go from objective-c to c++. AvatarButtonOwner?
AvatarButtonManager?

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/avatar_button_style.h (right):

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/avatar_button_style.h:9: enum AvatarButtonStyle
{
enum class?

[tapted, 2016-01-21 01:31:39]

Description was changed from

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonBridge` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonBridge::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonBridge

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

to

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonManager` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonManager::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonManager

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

[tapted, 2016-01-21 01:33:21]

PTAL

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/avatar_button_bridge.h (right):

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/avatar_button_bridge.h:15: class
AvatarButtonBridge : public views::ButtonListener {
On 2016/01/20 17:05:36, sky wrote:
> I'm curious why you're naming this with bridge. It doesn't seem at all like
the
> similarly named classes that go from objective-c to c++. AvatarButtonOwner?
> AvatarButtonManager?

Yeah - Bridge doesn't really fit. I've gone with AvatarButtonManager.

I also considered diverging a bit more and going with something like
"ProfileSwitcher". However, my lofty vision is to have this manage both the
profile switcher and the incognito indicator [and the CrOS
teleported-window-profile-indicator]. So AvatarButtonManager feels nice there.

I did end up keeping `profile_switcher_` as the data member name though. For
now, it ensures it doesn't get confused with `avatar_button_` (which is
[usually] the incognito icon - there's a todo to rename that already..).

history (re: "bridge"): In an earlier iteration it was effectively just bridging
the `NewAvatarButton` interface (i.e. in the design-pattern sense) by providing
the same API for hit-testing, layout, etc., but allowing code-sharing and
abstracting away the "might-not-exist" aspect. The layout has a lot of
frame-specific logic though, so this approach didn't buy much in the end.

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/avatar_button_style.h (right):

https://codereview.chromium.org/1608843002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/avatar_button_style.h:9: enum AvatarButtonStyle
{
On 2016/01/20 17:05:36, sky wrote:
> enum class?

Done.

[sky, 2016-01-21 14:36:45]

LGTM

[tapted, 2016-01-21 23:44:51]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-01-21 23:46:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608843002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608843002/120001

[commit-bot: I haz the power, 2016-01-22 00:22:25]

Description was changed from

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonManager` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonManager::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonManager

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

to

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonManager` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonManager::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonManager

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

[commit-bot: I haz the power, 2016-01-22 00:22:26]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-22 00:23:39]

Description was changed from

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonManager` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonManager::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonManager

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054
==========

to

==========
Start untangling the avatar switcher from BrowserNonClientFrameView

With Metro gone, Ash no longer needs the "new style" avatar switcher.
(ChromeOS never needed it).

MacViews will eventually want it, so start consolidating the logic so
that it can be reused. Hide the details of NewAvatarButton -- most
things just need a views::View.

Adds an `AvatarButtonManager` component, then
 - Moves BNCFV::UpdateNewAvatarButton() to AvatarButtonManager::Update()
 - Moves the many BNCFV*::ButtonPressed() handlers to AvatarButtonManager

The button-style enum moves to avatar_button_style.h so that the details
of NewAvatarButton can be properly encapsulated.

BUG=565989, 558054

Committed: https://crrev.com/1d9cf8afd778e64698fe69e43b9428453ee181d1
Cr-Commit-Position: refs/heads/master@{#370845}
==========

[commit-bot: I haz the power, 2016-01-22 00:23:40]

Patchset 7 (id:??) landed as
https://crrev.com/1d9cf8afd778e64698fe69e43b9428453ee181d1
Cr-Commit-Position: refs/heads/master@{#370845}