Issue 2005113002: Move Physical Web close button left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2005113002: Move Physical Web close button left (Closed)

Created:
4 years, 7 months ago by cco3

Modified:
4 years, 7 months ago

Reviewers:
nyquist

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move Physical Web close button left In the ListUrlsActivity, move the "close" button to the left in order to mimic the behavior of other chrome features, such as custom tabs. BUG=603132

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java	View		1 chunk	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nyquist

4 years, 7 months ago (2016-05-25 20:20:06 UTC) #3

interested parties don't seem excited about this, so maybe just close this CL?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages