Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

Issue 2005113002: Move Physical Web close button left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
index 48fb6b66621164d7d3bd877b53aa61b0e3cb99b9..f8a1b411600bb81e38ce7e869a0dde849fb49a75 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
@@ -127,28 +127,28 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
@Override
public boolean onCreateOptionsMenu(Menu menu) {
- Drawable tintedRefresh = ContextCompat.getDrawable(this, R.drawable.btn_toolbar_reload);
int tintColor = ContextCompat.getColor(this, R.color.light_normal_color);
- tintedRefresh.setColorFilter(tintColor, PorterDuff.Mode.SRC_IN);
- MenuItem refreshItem = menu.add(R.string.physical_web_refresh);
- refreshItem.setIcon(tintedRefresh);
- refreshItem.setShowAsAction(MenuItem.SHOW_AS_ACTION_ALWAYS);
- refreshItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
+ MenuItem closeItem = menu.add(R.string.close)
+ .setIcon(R.drawable.btn_close)
+ .setShowAsActionFlags(MenuItem.SHOW_AS_ACTION_ALWAYS);
+ closeItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
@Override
public boolean onMenuItemClick(MenuItem item) {
- startRefresh(true, false);
+ finish();
return true;
}
});
- MenuItem closeItem = menu.add(R.string.close);
- closeItem.setIcon(R.drawable.btn_close);
- closeItem.setShowAsAction(MenuItem.SHOW_AS_ACTION_ALWAYS);
- closeItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
+ Drawable tintedRefresh = ContextCompat.getDrawable(this, R.drawable.btn_toolbar_reload);
+ tintedRefresh.setColorFilter(tintColor, PorterDuff.Mode.SRC_IN);
+ MenuItem refreshItem = menu.add(R.string.physical_web_refresh)
+ .setIcon(tintedRefresh)
+ .setShowAsActionFlags(MenuItem.SHOW_AS_ACTION_ALWAYS);
+ refreshItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
@Override
public boolean onMenuItemClick(MenuItem item) {
- finish();
+ startRefresh(true, false);
return true;
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698