Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2005103003: Add implementations of mojo::{Run,Terminate}[Main]Application() for "chromium". (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add implementations of mojo::{Run,Terminate}[Main]Application() for "chromium". And convert a bunch of uses of ApplicationRunnerChromium (and ApplicationDelegate). Mostly, I converted stuff until I got bored. But: * I still have to convert some Mozart-related base classes. * I also have to fix the tracing library to not take an ApplicationImpl*. * I have to add the ability to set the message loop type. * I made Run[Main]Application() return MOJO_RESULT_OK by default (e.g., if the message loop was quit via something other than Terminate[Main]Application()), since it's what ApplicationRunner[Chromium] did (and some tests rely on this). We should fix this. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9030792b19912f334f058261e23c2b36bc091ce0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -174 lines) Patch
M examples/echo_terminal/main.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M examples/http_handler/http_handler.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M examples/notification_generator/notification_generator.cc View 5 chunks +24 lines, -29 lines 0 comments Download
M mojo/application/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A mojo/application/run_application.cc View 1 chunk +96 lines, -0 lines 2 comments Download
M mojo/public/cpp/application/lib/run_application.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/asset_bundle/main.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M services/authentication/main.cc View 5 chunks +11 lines, -15 lines 0 comments Download
M services/clipboard/main.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M services/icu_data/icu_data_impl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/icu_data/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/js/content_handler_main.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M services/log/main.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_nexe.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 5 chunks +13 lines, -14 lines 0 comments Download
M services/nacl/sfi/content_handler_main.cc View 4 chunks +17 lines, -19 lines 0 comments Download
M services/python/content_handler/content_handler_main.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M services/tracing/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/tracing/tracing_app.h View 3 chunks +4 lines, -5 lines 0 comments Download
M services/tracing/tracing_app.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-24 22:49:56 UTC) #1
viettrungluu
ping
4 years, 7 months ago (2016-05-25 17:41:23 UTC) #2
vardhan
lgtm https://codereview.chromium.org/2005103003/diff/1/mojo/application/run_application.cc File mojo/application/run_application.cc (right): https://codereview.chromium.org/2005103003/diff/1/mojo/application/run_application.cc#newcode34 mojo/application/run_application.cc:34: // |ApplicationRunnerChromium| always returned |MOJO_RESULT_OK|. would anything break ...
4 years, 7 months ago (2016-05-25 17:59:55 UTC) #3
viettrungluu
Thanks. https://codereview.chromium.org/2005103003/diff/1/mojo/application/run_application.cc File mojo/application/run_application.cc (right): https://codereview.chromium.org/2005103003/diff/1/mojo/application/run_application.cc#newcode34 mojo/application/run_application.cc:34: // |ApplicationRunnerChromium| always returned |MOJO_RESULT_OK|. On 2016/05/25 17:59:54, ...
4 years, 7 months ago (2016-05-25 18:10:07 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-25 18:25:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9030792b19912f334f058261e23c2b36bc091ce0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698