Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: mojo/public/cpp/application/lib/run_application.cc

Issue 2005103003: Add implementations of mojo::{Run,Terminate}[Main]Application() for "chromium". (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/application/lib/run_application.cc
diff --git a/mojo/public/cpp/application/lib/run_application.cc b/mojo/public/cpp/application/lib/run_application.cc
index 4ca4a1a4c435be8d7f087a7c1d8578a1e3ce5ae7..e34d245274639fbca39ac1f868cabae3257ab065 100644
--- a/mojo/public/cpp/application/lib/run_application.cc
+++ b/mojo/public/cpp/application/lib/run_application.cc
@@ -25,7 +25,9 @@ struct ResultHolder {
#ifndef NDEBUG
bool is_set = false;
#endif
- MojoResult result = MOJO_RESULT_UNKNOWN;
+ // TODO(vtl): The default result should probably be |MOJO_RESULT_UNKNOWN|, but
+ // |ApplicationRunner| always returned |MOJO_RESULT_OK|.
+ MojoResult result = MOJO_RESULT_OK;
};
pthread_key_t g_current_result_holder_key;

Powered by Google App Engine
This is Rietveld 408576698