Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2005093002: Remove non-standard 'results' attribute of INPUT element. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi, kinuko, Robert Sesek
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dshwang, eae+blinkwatch, jam, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-standard 'results' attribute of INPUT element. This CL remove the following web-exposed features: * 'results' content attribute * pseudo element '::-webkit-search-decoration' * pseudo element '::-webkit-search-results-decoration' * -webkit-appearance value 'searchfield-decoration' * -webkit-appearance value 'searchfield-results-decoration' Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8fHsOWz1XEw BUG=590117, 508935 Committed: https://crrev.com/b3cf60ab17dda681422128bc18d3de298375644e Cr-Commit-Position: refs/heads/master@{#395692}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -372 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer.sb View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +17 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/editing/undo/redo-after-detach.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/undo/redo-after-detach-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/placeholder-position.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/disabled-search-input.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/disabled-search-input-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-abs-pos-cancel-button.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-abs-pos-cancel-button-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/search/search-popup-crasher.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/search/search-popup-crasher-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-rtl.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-transformed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-transformed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-vertical-alignment.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-zoomed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-zoomed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/searchfield-heights.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/replaced/width100percent-searchfield.html View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/theme/search-field-results-decoration-crash.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/theme/search-field-results-decoration-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/scrollbars/custom-scrollbar-appearance-property.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/html.css View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.h View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/platform/ThemeTypes.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/blink_image_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/search_magnifier.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/search_magnifier_results.png View Binary file 0 comments Download

Messages

Total messages: 17 (9 generated)
tkent
Keishi, would you review the Blink part please?
4 years, 7 months ago (2016-05-24 04:14:43 UTC) #4
keishi
LGTM
4 years, 7 months ago (2016-05-24 05:12:30 UTC) #5
tkent
kinuko@, would you review content/child/blink_platform_impl.cc please? rsesek@, would you review content/renderer/renderer.sb please?
4 years, 7 months ago (2016-05-24 05:21:30 UTC) #7
kinuko
On 2016/05/24 05:21:30, tkent wrote: > kinuko@, would you review content/child/blink_platform_impl.cc please? content/ changes lgtm ...
4 years, 7 months ago (2016-05-24 05:40:58 UTC) #9
Robert Sesek
LGTM
4 years, 7 months ago (2016-05-24 13:47:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005093002/40001
4 years, 6 months ago (2016-05-24 21:02:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 6 months ago (2016-05-24 21:09:49 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-05-24 21:11:44 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3cf60ab17dda681422128bc18d3de298375644e
Cr-Commit-Position: refs/heads/master@{#395692}

Powered by Google App Engine
This is Rietveld 408576698