Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2005093002: Remove non-standard 'results' attribute of INPUT element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index c6606f82790e482843c755825efc67e64a653bee..1e3cf9fb3148968f90afeaf2ccecffffa97941c8 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -97,14 +97,12 @@ private:
// this, even when just clicking in the text field.
const int HTMLInputElement::maximumLength = 524288;
const int defaultSize = 20;
-const int maxSavedResults = 256;
HTMLInputElement::HTMLInputElement(Document& document, HTMLFormElement* form, bool createdByParser)
: HTMLTextFormControlElement(inputTag, document, form)
, m_size(defaultSize)
, m_maxLength(maximumLength)
, m_minLength(-1)
- , m_maxResults(-1)
, m_isChecked(false)
, m_dirtyCheckedness(false)
, m_isIndeterminate(false)
@@ -724,14 +722,6 @@ void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr
} else if (name == onsearchAttr) {
// Search field and slider attributes all just cause updateFromElement to be called through style recalcing.
setAttributeEventListener(EventTypeNames::search, createAttributeEventListener(this, name, value, eventParameterName()));
- } else if (name == resultsAttr) {
- int oldResults = m_maxResults;
- m_maxResults = !value.isNull() ? std::min(value.toInt(), maxSavedResults) : -1;
- // FIXME: Detaching just for maxResults change is not ideal. We should figure out the right
- // time to relayout for this change.
- if ((m_maxResults < 0) != (oldResults < 0))
- lazyReattachIfAttached();
- Deprecation::countDeprecation(document(), UseCounter::ResultsAttribute);
} else if (name == incrementalAttr) {
UseCounter::count(document(), UseCounter::IncrementalAttribute);
} else if (name == minAttr) {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | third_party/WebKit/Source/core/html/forms/SearchInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698