Change iOS web matcher argument types to std::string.

Change iOS web matcher argument types to std::string.

Most callers will be operating on GURLs, which are easier to use with
std::string, rather than NSString.

BUG=614167
Committed: https://crrev.com/89fa2012170971a09e3ae2536d6bedf9a711364d
Cr-Commit-Position: refs/heads/master@{#395589}

[baxley, 2016-05-23 23:19:59]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2016-05-23 23:19:59]

I tried changing the matcher APIs to pass std::string, instead of NSString. It
makes the test a little bit cleaner, and the helpers seem to be about the same.

I tested it locally using both forms of the APIs

https://codereview.chromium.org/2005023003/diff/1/ios/web/shell/test/earl_gre...
File ios/web/shell/test/earl_grey/shell_matchers.mm (right):

https://codereview.chromium.org/2005023003/diff/1/ios/web/shell/test/earl_gre...
ios/web/shell/test/earl_grey/shell_matchers.mm:26: }
The two preceding methods are a bit ugly, but I don't think it's worth doing
much to fix formatting since this is the code that will be removed with the API
goes away. Let me know what you think.

[Eugene But (OOO till 7-30), 2016-05-24 01:20:31]

Thanks! lgtm

https://codereview.chromium.org/2005023003/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_matchers.h (right):

https://codereview.chromium.org/2005023003/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.h:26: +
(id<GREYMatcher>)matcherForWebViewContainingText:(std::string)text
const std::string &

https://codereview.chromium.org/2005023003/diff/20001/ios/web/shell/test/earl...
File ios/web/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2005023003/diff/20001/ios/web/shell/test/earl...
ios/web/shell/test/earl_grey/shell_matchers.h:39: +
(id<GREYMatcher>)matcherForWebViewContainingText:(std::string)text;
const std::string&

https://codereview.chromium.org/2005023003/diff/20001/ios/web/shell/test/earl...
ios/web/shell/test/earl_grey/shell_matchers.h:42: +
(id<GREYMatcher>)matcherForAddressFieldEqualToText:(std::string)text;
const std::string&

[baxley, 2016-05-24 13:12:00]

Comments addressed.

https://codereview.chromium.org/2005023003/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_matchers.h (right):

https://codereview.chromium.org/2005023003/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.h:26: +
(id<GREYMatcher>)matcherForWebViewContainingText:(std::string)text
On 2016/05/24 01:20:31, Eugene But wrote:
> const std::string &

Done.

https://codereview.chromium.org/2005023003/diff/20001/ios/web/shell/test/earl...
File ios/web/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2005023003/diff/20001/ios/web/shell/test/earl...
ios/web/shell/test/earl_grey/shell_matchers.h:39: +
(id<GREYMatcher>)matcherForWebViewContainingText:(std::string)text;
On 2016/05/24 01:20:31, Eugene But wrote:
> const std::string&

Done.

https://codereview.chromium.org/2005023003/diff/20001/ios/web/shell/test/earl...
ios/web/shell/test/earl_grey/shell_matchers.h:42: +
(id<GREYMatcher>)matcherForAddressFieldEqualToText:(std::string)text;
On 2016/05/24 01:20:31, Eugene But wrote:
> const std::string&

Done.

[baxley, 2016-05-24 13:12:12]

The CQ bit was checked by baxley@chromium.org

[baxley, 2016-05-24 13:12:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2005023003/#ps40001
(title: "const &")

[commit-bot: I haz the power, 2016-05-24 13:12:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005023003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005023003/40001

[commit-bot: I haz the power, 2016-05-24 13:46:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 13:48:02]

Description was changed from

==========
Change iOS web matcher argument types to std::string.

Most callers will be operating on GURLs, which are easier to use with
std::string, rather than NSString.

BUG=614167
==========

to

==========
Change iOS web matcher argument types to std::string.

Most callers will be operating on GURLs, which are easier to use with
std::string, rather than NSString.

BUG=614167

Committed: https://crrev.com/89fa2012170971a09e3ae2536d6bedf9a711364d
Cr-Commit-Position: refs/heads/master@{#395589}
==========

[commit-bot: I haz the power, 2016-05-24 13:48:03]

Patchset 3 (id:??) landed as
https://crrev.com/89fa2012170971a09e3ae2536d6bedf9a711364d
Cr-Commit-Position: refs/heads/master@{#395589}