Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: ios/web/public/test/earl_grey/web_view_matchers.h

Issue 2005023003: Change iOS web matcher argument types to std::string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: const & Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/public/test/earl_grey/web_view_matchers.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/test/earl_grey/web_view_matchers.h
diff --git a/ios/web/public/test/earl_grey/web_view_matchers.h b/ios/web/public/test/earl_grey/web_view_matchers.h
index 1ff766b5037f7c2834b54ef0ff23ffac22056bc3..68066b1790c7b2c3b117fe0ed879f0db5a61b63f 100644
--- a/ios/web/public/test/earl_grey/web_view_matchers.h
+++ b/ios/web/public/test/earl_grey/web_view_matchers.h
@@ -2,21 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#import <string>
+
#import <EarlGrey/EarlGrey.h>
#import "ios/web/public/web_state/web_state.h"
namespace web {
+// TODO(crbug.com/614167): Remove this method when it is no longer used.
// Shorthand for GREYMatchers::matcherForWebViewContainingText:inWebState.
id<GREYMatcher> webViewContainingText(NSString* text, web::WebState* webState);
+// Shorthand for GREYMatchers::matcherForWebViewContainingText:inWebState.
+id<GREYMatcher> webViewContainingText(const std::string& text,
+ web::WebState* webState);
+
} // namespace web
@interface GREYMatchers (WebViewAdditions)
// Matcher for WKWebView containing |text|.
-+ (id<GREYMatcher>)matcherForWebViewContainingText:(NSString*)text
++ (id<GREYMatcher>)matcherForWebViewContainingText:(const std::string&)text
inWebState:(web::WebState*)webState;
@end
« no previous file with comments | « no previous file | ios/web/public/test/earl_grey/web_view_matchers.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698