chrome/browser/ui/omnibox/omnibox_navigation_observer.h - Issue 200493006: Move the ShortcutsBackend from history to autocomplete so that it can fully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_navigation_observer.h

Issue 200493006: Move the ShortcutsBackend from history to autocomplete so that it can fully (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/shortcuts_database.h ('K') | « chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc ('k') | chrome/browser/ui/omnibox/omnibox_navigation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_navigation_observer.h

===================================================================

--- chrome/browser/ui/omnibox/omnibox_navigation_observer.h (revision 256894)

+++ chrome/browser/ui/omnibox/omnibox_navigation_observer.h (working copy)

@@ -15,9 +15,7 @@

#include "content/public/browser/web_contents_observer.h"

#include "net/url_request/url_fetcher_delegate.h"

-namespace history {

class ShortcutsBackend;

namespace net {

class URLFetcher;

@@ -97,8 +95,8 @@

const base::string16 text_;

const AutocompleteMatch match_;

const AutocompleteMatch alternate_nav_match_;

- scoped_refptr<history::ShortcutsBackend> shortcuts_backend_; // May be NULL

- // in incognito.

+ scoped_refptr<ShortcutsBackend> shortcuts_backend_; // May be NULL in

Anuj 2014/03/15 00:51:05 May be? I think it should be NULL in incognito.

Peter Kasting 2014/03/17 18:36:44 Done.

+ // incognito.

scoped_ptr<net::URLFetcher> fetcher_;

LoadState load_state_;

FetchState fetch_state_;