Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 200493006: Move the ShortcutsBackend from history to autocomplete so that it can fully (Closed)

Created:
6 years, 9 months ago by Peter Kasting
Modified:
6 years, 9 months ago
Reviewers:
Anuj, rpetterson, brettw, sky
CC:
chromium-reviews, James Su, browser-components-watch_chromium.org
Visibility:
Public.

Description

Move the ShortcutsBackend from history to autocomplete so that it can fully depend on autocomplete types and functions without violating layering rules. Also fixes some minor style guide issues, e.g. non-private member variables. BUG=341137 TEST=none R=brettw@chromium.org, rlp@chromium.org, skanuj@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257826

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -1349 lines) Patch
M chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/shortcuts_backend.h View 1 10 chunks +19 lines, -64 lines 0 comments Download
A + chrome/browser/autocomplete/shortcuts_backend.cc View 1 2 3 15 chunks +63 lines, -121 lines 0 comments Download
A + chrome/browser/autocomplete/shortcuts_backend_factory.h View 1 4 chunks +5 lines, -8 lines 0 comments Download
A + chrome/browser/autocomplete/shortcuts_backend_factory.cc View 1 4 chunks +5 lines, -7 lines 0 comments Download
A + chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 2 5 chunks +139 lines, -90 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 2 3 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 1 2 3 9 chunks +28 lines, -16 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 2 3 7 chunks +13 lines, -22 lines 0 comments Download
D chrome/browser/history/shortcuts_backend.h View 1 2 3 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/history/shortcuts_backend.cc View 1 2 3 1 chunk +0 lines, -365 lines 0 comments Download
D chrome/browser/history/shortcuts_backend_factory.h View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/history/shortcuts_backend_factory.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/history/shortcuts_backend_unittest.cc View 1 2 3 1 chunk +0 lines, -206 lines 0 comments Download
M chrome/browser/history/shortcuts_database.h View 1 2 3 3 chunks +53 lines, -8 lines 0 comments Download
M chrome/browser/history/shortcuts_database.cc View 1 2 3 8 chunks +75 lines, -24 lines 0 comments Download
M chrome/browser/history/shortcuts_database_unittest.cc View 1 2 3 9 chunks +21 lines, -58 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_navigation_observer.h View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_navigation_observer.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Kasting
6 years, 9 months ago (2014-03-15 00:14:02 UTC) #1
Anuj
lgtm Some minor comment nits. I am more curious whether ShortcutsBackend is supposed to be ...
6 years, 9 months ago (2014-03-15 00:51:04 UTC) #2
Peter Kasting
+rlp for c/b/profiles/ OWNERS +sky for c/b/history/ and c/test/base/ OWNERS https://codereview.chromium.org/200493006/diff/20001/chrome/browser/history/shortcuts_database.h File chrome/browser/history/shortcuts_database.h (right): https://codereview.chromium.org/200493006/diff/20001/chrome/browser/history/shortcuts_database.h#newcode43 ...
6 years, 9 months ago (2014-03-17 18:36:43 UTC) #3
rpetterson
profiles/ lgtm
6 years, 9 months ago (2014-03-17 19:19:18 UTC) #4
sky
+brettw - he reviews the history related shortcut code chrome/test/base/testing_profile.cc LGTM
6 years, 9 months ago (2014-03-17 20:59:04 UTC) #5
brettw
lgtm
6 years, 9 months ago (2014-03-18 23:11:51 UTC) #6
Peter Kasting
6 years, 9 months ago (2014-03-19 00:13:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r257826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698