Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 200493004: Make the header/content separator into a hairline for apps in hidpi (Closed)

Created:
6 years, 9 months ago by pkotwicz
Modified:
6 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Make the header/content separator into a hairline for apps in hidpi In order to make the hairline header/content separator look good in HiDPI - The header/content separator overlays the window controls (to avoid a 1 physical pixel gap between the window controls and the header/content separator in 2x) - This CL makes the window controls 2 physical pixels taller in 2x - The bottom 1 physical pixel of the window control images is transparent. This is necessary because the window controls paint on top of the header/content separator BUG=340135 TEST=Manual, see bug R=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258301

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M ash/frame/custom_frame_view_ash_unittest.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M ash/frame/default_header_painter.cc View 3 chunks +12 lines, -10 lines 1 comment Download
M ash/frame/header_painter_util.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/resources/default_100_percent/common/window_control_background_hover.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/window_control_background_pressed.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/window_header_shade_bottom_inactive.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/window_header_shade_left_inactive.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/window_header_shade_right_inactive.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/window_control_background_hover.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/window_control_background_pressed.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/window_header_shade_bottom_inactive.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/window_header_shade_left_inactive.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/window_header_shade_right_inactive.png View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
James, can you please take a look? There was a similar CL that you looked ...
6 years, 9 months ago (2014-03-14 19:44:27 UTC) #1
James Cook
I'm just about to head to a school event. I'll look at this Monday, or ...
6 years, 9 months ago (2014-03-14 19:51:47 UTC) #2
James Cook
LGTM https://codereview.chromium.org/200493004/diff/80001/ash/frame/default_header_painter.cc File ash/frame/default_header_painter.cc (right): https://codereview.chromium.org/200493004/diff/80001/ash/frame/default_header_painter.cc#newcode304 ash/frame/default_header_painter.cc:304: // Draw the line as 1px thick regardless ...
6 years, 9 months ago (2014-03-17 16:55:59 UTC) #3
pkotwicz
6 years, 9 months ago (2014-03-20 15:05:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r258301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698