Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: ash/frame/custom_frame_view_ash_unittest.cc

Issue 200493004: Make the header/content separator into a hairline for apps in hidpi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/frame/default_header_painter.cc » ('j') | ash/frame/default_header_painter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/frame/custom_frame_view_ash_unittest.cc
diff --git a/ash/frame/custom_frame_view_ash_unittest.cc b/ash/frame/custom_frame_view_ash_unittest.cc
index 299b983415c4f1151ad08a7b13cbd775f7283a62..eb0a543d3f11af36c41e84f0a38e4329b3198473 100644
--- a/ash/frame/custom_frame_view_ash_unittest.cc
+++ b/ash/frame/custom_frame_view_ash_unittest.cc
@@ -113,19 +113,9 @@ TEST_F(CustomFrameViewAshTest, HeaderHeight) {
gfx::ImageSkia* close_button =
rb.GetImageSkiaNamed(IDR_AURA_WINDOW_CONTROL_BACKGROUND_H);
- // |kSeparatorSize| should match |kHeaderContentSeparatorSize| in
- // default_header_painter.cc
- // TODO(pkotwicz): Clean this test up once the separator overlays the window
- // controls.
- const int kSeparatorSize = 1;
-
- // The header should have enough room for the window controls and the
- // separator line.
- EXPECT_EQ(close_button->height() + kSeparatorSize,
- delegate->custom_frame_view()->GetHeaderView()->height());
-
- widget->Maximize();
- EXPECT_EQ(close_button->height() + kSeparatorSize,
+ // The header should have enough room for the window controls. The
+ // header/content separator line overlays the window controls.
+ EXPECT_EQ(close_button->height(),
delegate->custom_frame_view()->GetHeaderView()->height());
}
« no previous file with comments | « no previous file | ash/frame/default_header_painter.cc » ('j') | ash/frame/default_header_painter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698