third_party/WebKit/Source/bindings/core/v8/V8Binding.h - Issue 2004643002: Implement BroadcastChannel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2004643002: Implement BroadcastChannel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert to mojo interface of PS4 to have less logic in renderer Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webmessaging/public/interfaces/broadcast_channel.mojom ('K') | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt ('k') | third_party/WebKit/Source/core/events/EventTargetFactory.in » ('j') | third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

index e81bdd29998b3d137c3d5cc2807352d5ab37e358..7f3d6eebaf0db8917ce7e5b7929cca033e780f86 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

@@ -83,7 +83,7 @@ struct V8TypeOf {

// Helpers for throwing JavaScript TypeErrors for arity mismatches.

CORE_EXPORT void setArityTypeError(ExceptionState&, const char* valid, unsigned provided);

CORE_EXPORT v8::Local<v8::Value> createMinimumArityTypeErrorForMethod(v8::Isolate*, const char* method, const char* type, unsigned expected, unsigned provided);

-v8::Local<v8::Value> createMinimumArityTypeErrorForConstructor(v8::Isolate*, const char* type, unsigned expected, unsigned provided);

+CORE_EXPORT v8::Local<v8::Value> createMinimumArityTypeErrorForConstructor(v8::Isolate*, const char* type, unsigned expected, unsigned provided);

kinuko 2016/06/09 09:14:58 is this related? (wasn't very obvious to me...)

Marijn Kruisselbrink 2016/06/22 18:46:56 The bindings generated code for a constructor can

CORE_EXPORT void setMinimumArityTypeError(ExceptionState&, unsigned expected, unsigned provided);

template<typename CallbackInfo, typename S>